Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chemical heaters now scale from max_temprature not target temprerature #10624

Merged
merged 4 commits into from
Dec 12, 2020
Merged

Chemical heaters now scale from max_temprature not target temprerature #10624

merged 4 commits into from
Dec 12, 2020

Conversation

redmoogle
Copy link
Contributor

Intent of your Pull Request

Makes it so the equation isnt (target - current) and instead (1000 - current) * -1(or1)

Takes about ~8 seconds for a unupgraded heater to hit 380K
Should take about ~2 seconds at Tier 4

Tested AND works backwards

Why is this good for the game?

Muh Realism. Also prevents just bypassing the need for heating by have chemicals be 1 tick
also fixes a slight bug where it would never reach target temperature

Changelog

🆑
tweak: Chem heaters now scale based on max temperature
/:cl:

@Yogbot-13 Yogbot-13 added the Tweak This PR contains changes to the game. label Dec 9, 2020
@athena413
Copy link
Contributor

muh speed muh danger meth explodes

good pr

Copy link
Contributor

@TheGamerdk TheGamerdk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

turd code

don't like that if statement but i'm too lazy to figure out an elegant way to remove it

code/modules/reagents/chemistry/machinery/chem_heater.dm Outdated Show resolved Hide resolved
code/modules/reagents/chemistry/machinery/chem_heater.dm Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Tweak This PR contains changes to the game.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants