-
-
Notifications
You must be signed in to change notification settings - Fork 447
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PORT] Secret Gateways: Config loaded Away Missions + Anti-observing Z level traits #13967
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ggering from abstract effects & co. (#54783)
admins are now notified about a secret gateway load failing, also logs this secret z levels are protected from incorporeal movement fixes unpowered ruin areas being powered adds a bunch of new areas for secret gateways, since var edited areas probably arent a good idea its good to have a few presets adds cordon turfs and areas, ingame they just look like the z level border, they are completely indestructible, you cant pass them, and if you somehow do, the cordon area kills you (idea from goon but the code and sprites are mine) adds a z level injector mapping trait, injects a z level trait into the z level its placed on, if you want to add something like ash storms or whatever to your map adds an anti xray z level trait, you can optionally add this with the z level injector to protect your map against any xray or whatever
Yessss finally I've been waiting on this forever |
What happens if someone tries to observe an admin ghost on a secret z level? And it is admin ghosts, not just ghosts of an admin right? |
adamsong
previously requested changes
May 4, 2022
Memory Concerns will test later |
this doesn't do anything at present |
JamieD1
approved these changes
May 16, 2022
JamieD1
approved these changes
May 16, 2022
Art not required, mapping helper non player seen. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Document the changes in your pull request
Ports tgstation/tgstation#61719
Adds secret gateways, these away missions are map files loaded from a config folder, instead of being files in the repo.
![image](https://user-images.githubusercontent.com/5618080/166239573-b2fea754-295c-413c-9fe2-370bef242d36.png)
![image](https://user-images.githubusercontent.com/5618080/166239590-8f192fbf-6993-4552-8b0d-3758ce7d8d0d.png)
![image](https://user-images.githubusercontent.com/5618080/166239607-9d95835d-ae93-4e19-ac1b-60c0dac5b2dc.png)
The chance of an away mission being a secret one is config dependant.
Secret away missions have a secret z level trait applied to them, making them not visible by ghosts (other than admin ghosts) other than looking through another player's eyes (you dont get xray like you normally do) with the Observe verb like in the image below.
Until there are maps added to the folder and someone sets the config up, no secret away missions will show up on the servers.
Adds a map report verb for viewing map reports
If the map has errors in it, it doesn't load and it creates a map report
In addition you no longer squeak if you're flying or have no gravity
Squeaks happen when projectiles hit stuff
Wiki Documentation
Changelog
🆑 Fikou, ported by TheGamerDK
rscadd: Secret Gateways can now be a thing enabled by config. They are not on the repository, instead, loaded from a config folder.
rscadd: Adds the secret and anti-phasing z level traits used by Secret Gateways, secret prevents observers from looking at the z level in any way other than observing through another player's eyes
experimental: admin loaded away missions can be secret as well
/:cl: