Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PORT] Secret Gateways: Config loaded Away Missions + Anti-observing Z level traits #13967

Merged
merged 8 commits into from
May 16, 2022

Conversation

TheGamerdk
Copy link
Contributor

@TheGamerdk TheGamerdk commented May 2, 2022

Document the changes in your pull request

Ports tgstation/tgstation#61719

Adds secret gateways, these away missions are map files loaded from a config folder, instead of being files in the repo.
The chance of an away mission being a secret one is config dependant.
Secret away missions have a secret z level trait applied to them, making them not visible by ghosts (other than admin ghosts) other than looking through another player's eyes (you dont get xray like you normally do) with the Observe verb like in the image below.
image
Until there are maps added to the folder and someone sets the config up, no secret away missions will show up on the servers.
Adds a map report verb for viewing map reports
image
If the map has errors in it, it doesn't load and it creates a map report
image

In addition you no longer squeak if you're flying or have no gravity
Squeaks happen when projectiles hit stuff

Wiki Documentation

Changelog

🆑 Fikou, ported by TheGamerDK
rscadd: Secret Gateways can now be a thing enabled by config. They are not on the repository, instead, loaded from a config folder.
rscadd: Adds the secret and anti-phasing z level traits used by Secret Gateways, secret prevents observers from looking at the z level in any way other than observing through another player's eyes
experimental: admin loaded away missions can be secret as well
/:cl:

Fikou and others added 8 commits May 2, 2022 14:12
admins are now notified about a secret gateway load failing, also logs this
secret z levels are protected from incorporeal movement
fixes unpowered ruin areas being powered
adds a bunch of new areas for secret gateways, since var edited areas probably arent a good idea its good to have a few presets
adds cordon turfs and areas, ingame they just look like the z level border, they are completely indestructible, you cant pass them, and if you somehow do, the cordon area kills you (idea from goon but the code and sprites are mine)
adds a z level injector mapping trait, injects a z level trait into the z level its placed on, if you want to add something like ash storms or whatever to your map
adds an anti xray z level trait, you can optionally add this with the z level injector to protect your map against any xray or whatever
@TheGamerdk TheGamerdk requested review from a team as code owners May 2, 2022 13:22
@Yogbot-13 Yogbot-13 added the Feature This adds new content to the game label May 2, 2022
@github-actions github-actions bot added the Admin This PR affects administrators label May 2, 2022
@neeshacark
Copy link
Contributor

Yessss finally I've been waiting on this forever

@adamsong
Copy link
Contributor

adamsong commented May 4, 2022

What happens if someone tries to observe an admin ghost on a secret z level? And it is admin ghosts, not just ghosts of an admin right?

code/datums/components/squeak.dm Show resolved Hide resolved
code/datums/components/squeak.dm Show resolved Hide resolved
@JamieD1
Copy link
Contributor

JamieD1 commented May 5, 2022

Memory Concerns will test later

@TheGamerdk
Copy link
Contributor Author

Memory Concerns will test later

this doesn't do anything at present

@JamieD1
Copy link
Contributor

JamieD1 commented May 16, 2022

Art not required, mapping helper non player seen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Admin This PR affects administrators Feature This adds new content to the game
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants