Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Secret Gateways: Config loaded Away Missions + Anti-observing Z level traits #61719

Merged
merged 5 commits into from Sep 28, 2021

Conversation

Fikou
Copy link
Member

@Fikou Fikou commented Sep 26, 2021

About The Pull Request

Adds secret gateways, these away missions are map files loaded from a config folder, instead of being files in the repo.
The chance of an away mission being a secret one is config dependant.
Secret away missions have a secret z level trait applied to them, making them not visible by ghosts (other than admin ghosts) other than looking through another player's eyes (you dont get xray like you normally do) with the Observe verb like in the image below.
image
Until there are maps added to the folder and someone sets the config up, no secret away missions will show up on the servers.
Adds a map report verb for viewing map reports
image
If the map has errors in it, it doesn't load and it creates a map report
image

Why It's Good For The Game

content that cant be code dived seems fun at least to try out.

Changelog

🆑
add: Secret Gateways can now be a thing enabled by config. They are not on the repository, instead, loaded from a config folder.
add: Adds the secret and anti-phasing z level traits used by Secret Gateways, secret prevents observers from looking at the z level in any way other than observing through another player's eyes
admin: admin loaded away missions can be secret as well
/:cl:

@tgstation-server tgstation-server added Config Update Time to bother the headadmins for three months to get your config applied Feature Exposes new bugs in interesting ways labels Sep 26, 2021
@Watermelon914 Watermelon914 changed the title $$$ekret Gateways Secret Gateways Sep 26, 2021
code/modules/mob/dead/observer/observer.dm Show resolved Hide resolved
code/modules/mob/living/death.dm Outdated Show resolved Hide resolved
code/modules/mob/dead/observer/observer.dm Outdated Show resolved Hide resolved
@wesoda25
Copy link
Contributor

Athath nerf

@ATH1909
Copy link
Contributor

ATH1909 commented Sep 26, 2021

Athath nerf

:walter:

@MMMiracles
Copy link
Contributor

is there any talk about how these will be submitted/maintained since the idea is that they aren't easily seen on the repo? i think this is a really good step towards making more long-term away missions and knowing they won't be immediately mapped out within a week gives me a lot of hope for their revival

@Fikou
Copy link
Member Author

Fikou commented Sep 26, 2021

is there any talk about how these will be submitted/maintained since the idea is that they aren't easily seen on the repo? i think this is a really good step towards making more long-term away missions and knowing they won't be immediately mapped out within a week gives me a lot of hope for their revival

this depends on the headmins but im hopeful we can get a good system going for it, would be good to start a policy discussion thread on it when the forums go back up maybe

@Mothblocks
Copy link
Member

This is pretty spooky since changing things like paths or var-edits is going to be completely unnoticed, especially since gateways are only loaded at specific times.

It's going to effectively be mandatory now if we want these up to date that the path change tool is always updated even for small changes, though even that won't make var-edit changes possible. Any big refactor like that disposals one (I think?) will just break these until someone A. notices and B. has the power to fix it. (Also, I don't even think the path change tool, works.)

It's good to see the map report tools and that it's blocked from loading if it doesn't align, I'm just worried about the future. I'm not blocking this.

code/__DEFINES/maps.dm Outdated Show resolved Hide resolved
code/__DEFINES/maps.dm Outdated Show resolved Hide resolved
code/__DEFINES/maps.dm Outdated Show resolved Hide resolved
code/modules/awaymissions/zlevel.dm Show resolved Hide resolved
code/modules/awaymissions/zlevel.dm Outdated Show resolved Hide resolved
code/modules/mapping/verify.dm Show resolved Hide resolved
code/modules/mob/dead/observer/observer.dm Show resolved Hide resolved
@Mothblocks Mothblocks marked this pull request as draft September 26, 2021 23:09
@Mothblocks Mothblocks marked this pull request as draft September 26, 2021 23:09
@Fikou Fikou marked this pull request as ready for review September 26, 2021 23:32
@MrDoomBringer
Copy link
Contributor

MrDoomBringer commented Sep 27, 2021

This is pretty spooky since changing things like paths or var-edits is going to be completely unnoticed, especially since gateways are only loaded at specific times.

Would hosting these maps on a private downstream repo help us catch broken maps faster?

@Fikou
Copy link
Member Author

Fikou commented Sep 27, 2021

This is pretty spooky since changing things like paths or var-edits is going to be completely unnoticed, especially since gateways are only loaded at specific times.

Would hosting these maps on a private downstream repo help us catch broken maps faster?

broken maps should be caught pretty fast with the game reporting them and the reports being viewable, the issue is getting an "input and output" from server files, so people that care about maintaining the maps can do it

@drIcepop
Copy link

That first picture looks like Biodome, telesci clause in TG?!?!?!

@Watermelon914
Copy link
Member

This is pretty spooky since changing things like paths or var-edits is going to be completely unnoticed, especially since gateways are only loaded at specific times.

It's going to effectively be mandatory now if we want these up to date that the path change tool is always updated even for small changes, though even that won't make var-edit changes possible. Any big refactor like that disposals one (I think?) will just break these until someone A. notices and B. has the power to fix it. (Also, I don't even think the path change tool, works.)

It's good to see the map report tools and that it's blocked from loading if it doesn't align, I'm just worried about the future. I'm not blocking this.

It's up to the headadmins how they want to run this but I was thinking they rotate maps every few weeks or so instead of having a map in forever.
If a map deserves to be in the configs for more than 2-3 months, then it should probably just be PR'd to the repo as an away mission.

@Fikou
Copy link
Member Author

Fikou commented Sep 27, 2021

That first picture looks like Biodome, telesci clause in TG?!?!?!

so true bestie

@Timberpoes
Copy link
Member

Ultimately it will be up to the headmins and MSO to set up the infrastructure and team for uploading and maintaining these private gateway maps.

The private gateway map team will be required to update and maintain these private gateway maps independent of the codebase.

In addition with the new z-level trait that hides it from observers - I often stand alone when I say I'd like to limit observer information so they are not omnipotent. People from up and down the admin team and maintainer team, as well as MSO, have expressed discontent at attempts taken to restrict or remove observer's information. I feel that should also be discussed before this is merged.

@Fikou
Copy link
Member Author

Fikou commented Sep 27, 2021

well timber we cant really do that until someone that dislikes restricting observers shows up here!

@Mothblocks
Copy link
Member

We already limit observer information especially for admin stuff. Admin circuits don't let you look inside them because of loser powergamers.

@Fikou Fikou changed the title Secret Gateways Secret Gateways: Config loaded Away Missions + Anti-observing Z level traits Sep 28, 2021
@Mothblocks Mothblocks merged commit 74be623 into tgstation:master Sep 28, 2021
github-actions bot added a commit that referenced this pull request Sep 28, 2021
EOBGames added a commit to EOBGames/tgstation that referenced this pull request Sep 29, 2021
commit c10e1e6
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Tue Sep 28 20:55:39 2021 -0700

    Automatic changelog generation for PR tgstation#61746 [ci skip]

commit 9bcc80c
Author: 567Turtle <91508746+567Turtle@users.noreply.github.com>
Date:   Tue Sep 28 22:55:36 2021 -0500

    Constructable Filing Cabinets (tgstation#61746)

commit 2fd4e1d
Author: tralezab <40974010+tralezab@users.noreply.github.com>
Date:   Tue Sep 28 19:12:45 2021 -0700

    adds tralezab as a codeowner of datum ais (tgstation#61769)

commit f45fb5d
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Tue Sep 28 17:52:34 2021 -0700

    Automatic changelog generation for PR tgstation#61739 [ci skip]

commit 8473d44
Author: Zytolg <33048583+Zytolg@users.noreply.github.com>
Date:   Tue Sep 28 18:52:30 2021 -0600

    Ditches the Spare Monkey-Operated Firealarm in Kilostaiton Genetics (tgstation#61739)

    Co-authored-by: Zytolg <theoriginaldash@gmail,com>

commit e135108
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Tue Sep 28 17:52:14 2021 -0700

    Automatic changelog generation for PR tgstation#61738 [ci skip]

commit b626fad
Author: Zytolg <33048583+Zytolg@users.noreply.github.com>
Date:   Tue Sep 28 18:52:10 2021 -0600

    Removes Duplicate Disposals Pipe and Glass Table from MetaENG (tgstation#61738)

    * Removes Duplicate Disposals Pipe and Glass Table from MetaENG

    * Plumbing and Power too

    Co-authored-by: Zytolg <theoriginaldash@gmail,com>

commit 87cf6e7
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Tue Sep 28 17:51:28 2021 -0700

    Automatic changelog generation for PR tgstation#61733 [ci skip]

commit 6174323
Author: esainane <esainane+github@gmail.com>
Date:   Wed Sep 29 13:51:25 2021 +1300

    Derelict: Remove duplicate APCs (tgstation#61733)

    Two APCs were fighting for control over
    `/area/ruin/space/derelict/bridge/access` at (66,80) and (63,61).
    This removes the APC at (63,61) and the two wires leading up to it.

    Two APCs were fighting for control over
    `/area/ruin/space/derelict/hallway/secondary` at (35,23) and (58,24).
    This removes the APC at (58,24), which is directly over a wire path,
    so does not require any power cables to be removed.

commit a43209f
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Tue Sep 28 17:51:11 2021 -0700

    Automatic changelog generation for PR tgstation#61735 [ci skip]

commit 9e40039
Author: Iamgoofball <iamgoofball@gmail.com>
Date:   Tue Sep 28 17:51:08 2021 -0700

    Fixes references to now dead gangs in Families objectives. (tgstation#61735)

commit 44c424f
Author: Changelogs <action@github.com>
Date:   Wed Sep 29 00:11:00 2021 +0000

    Automatic changelog compile [ci skip]

commit 9d200cb
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Tue Sep 28 17:07:45 2021 -0700

    Automatic changelog generation for PR tgstation#61532 [ci skip]

commit 65267ba
Author: Krysonism <49783092+Krysonism@users.noreply.github.com>
Date:   Wed Sep 29 02:07:41 2021 +0200

    Cytology Adjacent Update #1: New pet food, made from pets. Buffs health of selected simple mobs. (tgstation#61532)

    * doggy dog world

    * space begone

    * suggestions from review

    * removes frog related oopsie

    * indent fix

commit 67194ea
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Tue Sep 28 16:52:16 2021 -0700

    Automatic changelog generation for PR tgstation#61722 [ci skip]

commit 61c30cc
Author: Arkatos1 <43862960+Arkatos1@users.noreply.github.com>
Date:   Wed Sep 29 01:52:12 2021 +0200

    ntoscard templates fix (tgstation#61722)

commit 378da49
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Tue Sep 28 16:47:47 2021 -0700

    Automatic changelog generation for PR tgstation#61730 [ci skip]

commit 81989f0
Author: TiviPlus <57223640+TiviPlus@users.noreply.github.com>
Date:   Wed Sep 29 01:47:44 2021 +0200

    Fix baselighting not respecting changeturfs (tgstation#61730)

commit 1846c2d
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Tue Sep 28 15:03:30 2021 -0700

    Automatic changelog generation for PR tgstation#61716 [ci skip]

commit e330485
Author: Thunder12345 <Thunder12345@users.noreply.github.com>
Date:   Tue Sep 28 23:03:27 2021 +0100

    Replaces CTF hardsuits with new armoured vests (tgstation#61716)

    Co-authored-by: Thunder12345 <stewart@critar.demon.co.uk>

commit 84c7b68
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Tue Sep 28 14:21:30 2021 -0700

    Automatic changelog generation for PR tgstation#61736 [ci skip]

commit 643645b
Author: Imaginos16 <77556824+Imaginos16@users.noreply.github.com>
Date:   Tue Sep 28 18:21:27 2021 -0300

    Makes colo cup sprites actually consistent, and a small edit to a joke. (tgstation#61736)

    * Update drinks.dm

    * adds actual colo cups sprites lol im dumb

    * fixes a small sprite error

commit c1fd222
Author: John Willard <53777086+JohnFulpWillard@users.noreply.github.com>
Date:   Tue Sep 28 17:16:09 2021 -0400

    dehardcodes limb icons (tgstation#61570)

    This is a small change aimed at helping downstream modularity.
    Currently the file these sprites use are hardcoded with a define, this removes that and instead moves it to a var.

    I guess the thing is defaults should be overridable, it's just we've never ran into a case where it's needed, so adding that functionality on its own looks really weird

    annoying. I don't like adding stuff that's only useful to downstreams, for various reasons, but this seems ok after some thought. fulfills the promise of _DEFAULT.
    -Lemon

commit eec8463
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Tue Sep 28 12:45:42 2021 -0700

    Automatic changelog generation for PR tgstation#61694 [ci skip]

commit 496a768
Author: Mooshimi <85910816+Mooshimi@users.noreply.github.com>
Date:   Tue Sep 28 15:45:38 2021 -0400

    [MDB Ignore] Make shuttle windows deconstructable (tgstation#61694)

    * shuttle windows

    * refactor reinf windows

    plasma and shuttle only

    * messed up one change

    * i am actually blind

    * made and did file

commit a66ef31
Author: MrMelbert <51863163+MrMelbert@users.noreply.github.com>
Date:   Tue Sep 28 14:15:11 2021 -0500

    Corrects mapload args that sprug up in the past few days (tgstation#61759)

    See tgstation#61623 . These were either merged after the prior PR, coded before the prior PR, or were made in between and not updated.

commit 4fc5897
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Tue Sep 28 11:56:21 2021 -0700

    Automatic changelog generation for PR tgstation#61725 [ci skip]

commit 43a2b90
Author: Fikou <23585223+Fikou@users.noreply.github.com>
Date:   Tue Sep 28 20:56:17 2021 +0200

    renames enable debug verbs to enable mapping verbs (tgstation#61725)

    its such a stupid fucking name, the verbs are all mapping related, they are all in the mapping tab, nobody knows about them because its called debug verbs for some reason instead of mapping verbs

commit 4413bbc
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Tue Sep 28 08:00:07 2021 -0700

    Automatic changelog generation for PR tgstation#61724 [ci skip]

commit a23b275
Author: Mothblocks <35135081+Mothblocks@users.noreply.github.com>
Date:   Tue Sep 28 08:00:01 2021 -0700

    Fixes check AI laws collapsing, making them unreadable (tgstation#61724)

    Previously, this would be putting (x2) next to the first 3 laws, and it would look like the 2nd cyborg had no laws.

commit a62262f
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Tue Sep 28 07:58:50 2021 -0700

    Automatic changelog generation for PR tgstation#61723 [ci skip]

commit 4eee6a1
Author: Timberpoes <silent_insomnia_pp@hotmail.co.uk>
Date:   Tue Sep 28 15:58:47 2021 +0100

    Fixes contractor drop pods not being clickable due to suspected BYOND issue. (tgstation#61723)

    Fixes tgstation#61695

    When breaking the entire problem down, I identified the point in time at which the pod stopped being clickable
    Spawning in pods manually and running their various procs couldn't replicate the issue. As a result, I eliminated pod code as the root cause and focused on the pod_landingzone that control them.

    I considered the debris as a possible cause following:
    tgstation#61695

    However, removing the debris actually removed ALL clickable area for the pods. The debris overlap was the only part that let me click on the pods.

    So then I set to hacking away at any animation code. At one point I removed both the animates

    animate(pod.get_filter("motionblur"), y = 0, time = pod.delays[POD_FALLING], flags = ANIMATION_PARALLEL)
    animate(pod, pixel_z = -1 * abs(sin(rotation))*4, pixel_x = SUPPLYPOD_X_OFFSET + (sin(rotation) * 20), time = pod.delays[POD_FALLING], easing = LINEAR_EASING, flags = ANIMATION_PARALLEL) //Make the pod fall! At an angle!
    from /obj/effect/pod_landingzone/proc/beginLaunch and the problem still persisted.

    When I removed pod.add_filter("motionblur",1,list("type"="motion_blur", "x"=0, "y"=3)) after this (the effect was permanently on the pod which made it pretty obvious as a possible cause) the problem vanished entirely.

    Without the motion blur filter applied, pods now function properly.

    As a result, I believe this is a BYOND issue. Someone with more brains than me can probably work out a test case. Until someone with more brains than me comes along to fix it, removing the motion blur filter is my solution.

commit 1859df5
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Tue Sep 28 07:55:59 2021 -0700

    Automatic changelog generation for PR tgstation#61229 [ci skip]

commit 29c49fd
Author: dragomagol <66640614+dragomagol@users.noreply.github.com>
Date:   Tue Sep 28 07:55:55 2021 -0700

    Ports animated locker doors (tgstation#61229)

    ## About The Pull Request
    Ports locker door animations from Yogstation!

    yogstation13/Yogstation#9706
    Skyrat-SS13/Skyrat-tg#6767

    ## Why It's Good For The Game
    The locker opening animation is really nice, it's a shame we don't have it yet.

commit 6189b88
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Tue Sep 28 02:08:57 2021 -0700

    Automatic changelog generation for PR tgstation#61692 [ci skip]

commit df1260f
Author: CRITAWAKETS <sebastienracicot@hotmail.com>
Date:   Tue Sep 28 05:08:53 2021 -0400

    Fixes the auxiliary base construction console. (tgstation#61692)

commit c254707
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Tue Sep 28 02:05:30 2021 -0700

    Automatic changelog generation for PR tgstation#61698 [ci skip]

commit 6317b7b
Author: TiviPlus <57223640+TiviPlus@users.noreply.github.com>
Date:   Tue Sep 28 11:05:27 2021 +0200

    Fix connect loc not respecting phasing in some cases when it should (tgstation#61698)

commit 26df314
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Tue Sep 28 00:01:11 2021 -0700

    Automatic changelog generation for PR tgstation#60920 [ci skip]

commit ff41f8a
Author: twilightwanderer <88540658+twilightwanderer@users.noreply.github.com>
Date:   Tue Sep 28 10:01:07 2021 +0300

    Fixing the chat client (tgstation#60920)

    Corrects the chat restriction on using ASII characters only. (This PR was created for Skyrat-TG, but the collaborator of that repository asked me to adapt this PR for tgstation.)

    This will fix tgstation#54598
    In the original code, the chat client uses only ASII standard characters, which is very limited in its capabilities. For example, does not allow you to use specialized characters, which would have taken the atmosphere of the old messengers, as well as regional characters. The lack of regional characters complicates the game for non-English-speaking servers. For example, the Russian-speaking player community Space Station 13 The Fluffy Frontier uses the original Skyrat-tg build. And the players of this community almost do not use the chat client to communicate due to the fact that they can not use Cyrillic characters.

commit 3b275f8
Author: Sheits <81964183+Sheits@users.noreply.github.com>
Date:   Tue Sep 28 16:57:52 2021 +1000

    Creates fly.ts for the new tgui prefs menu (tgstation#61728)

    Co-authored-by: Mothblocks <35135081+Mothblocks@users.noreply.github.com>

commit 32518f6
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Mon Sep 27 22:52:08 2021 -0700

    Automatic changelog generation for PR tgstation#61715 [ci skip]

commit 76c6754
Author: Fikou <23585223+Fikou@users.noreply.github.com>
Date:   Tue Sep 28 07:52:05 2021 +0200

    secret recipes are now actually secret (tgstation#61715)

commit 67e7261
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Mon Sep 27 20:38:52 2021 -0700

    Automatic changelog generation for PR tgstation#61714 [ci skip]

commit 1f000ba
Author: Mothblocks <35135081+Mothblocks@users.noreply.github.com>
Date:   Mon Sep 27 20:38:49 2021 -0700

    Fix word bounds on filters, where they would only be applied at the beginning (tgstation#61714)

commit 563cb1d
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Mon Sep 27 19:06:06 2021 -0700

    Automatic changelog generation for PR tgstation#61607 [ci skip]

commit 744679b
Author: Zytolg <33048583+Zytolg@users.noreply.github.com>
Date:   Mon Sep 27 20:06:02 2021 -0600

    Adds brand new ruins to the Icebox Ruins roster. (tgstation#61607)

commit 69fc80f
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Mon Sep 27 17:52:00 2021 -0700

    Automatic changelog generation for PR tgstation#61680 [ci skip]

commit dbfa6c0
Author: NamelessFairy <40036527+NamelessFairy@users.noreply.github.com>
Date:   Tue Sep 28 01:51:57 2021 +0100

    Fix Genturf on Icebox (tgstation#61680)

commit a19f273
Author: Changelogs <action@github.com>
Date:   Tue Sep 28 00:11:28 2021 +0000

    Automatic changelog compile [ci skip]

commit c277a6f
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Mon Sep 27 17:08:07 2021 -0700

    Automatic changelog generation for PR tgstation#61621 [ci skip]

commit 3c5d622
Author: Ghom <42542238+Ghommie@users.noreply.github.com>
Date:   Tue Sep 28 02:08:03 2021 +0200

    You can now use backslashes as an escape character for text modification. (tgstation#61621)

commit eac67c9
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Mon Sep 27 17:04:30 2021 -0700

    Automatic changelog generation for PR tgstation#61719 [ci skip]

commit 74be623
Author: Fikou <23585223+Fikou@users.noreply.github.com>
Date:   Tue Sep 28 02:04:27 2021 +0200

    Secret Gateways: Config loaded Away Missions + Anti-observing Z level traits (tgstation#61719)

commit ca4524e
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Mon Sep 27 16:35:18 2021 -0700

    Automatic changelog generation for PR tgstation#61726 [ci skip]

commit d9ede13
Author: tralezab <40974010+tralezab@users.noreply.github.com>
Date:   Mon Sep 27 16:35:15 2021 -0700

    if you give a monkey an instrument, it will begin playing the donkey kong theme (tgstation#61726)
EOBGames added a commit to EOBGames/tgstation that referenced this pull request Sep 29, 2021
commit c10e1e6
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Tue Sep 28 20:55:39 2021 -0700

    Automatic changelog generation for PR tgstation#61746 [ci skip]

commit 9bcc80c
Author: 567Turtle <91508746+567Turtle@users.noreply.github.com>
Date:   Tue Sep 28 22:55:36 2021 -0500

    Constructable Filing Cabinets (tgstation#61746)

commit 2fd4e1d
Author: tralezab <40974010+tralezab@users.noreply.github.com>
Date:   Tue Sep 28 19:12:45 2021 -0700

    adds tralezab as a codeowner of datum ais (tgstation#61769)

commit f45fb5d
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Tue Sep 28 17:52:34 2021 -0700

    Automatic changelog generation for PR tgstation#61739 [ci skip]

commit 8473d44
Author: Zytolg <33048583+Zytolg@users.noreply.github.com>
Date:   Tue Sep 28 18:52:30 2021 -0600

    Ditches the Spare Monkey-Operated Firealarm in Kilostaiton Genetics (tgstation#61739)

    Co-authored-by: Zytolg <theoriginaldash@gmail,com>

commit e135108
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Tue Sep 28 17:52:14 2021 -0700

    Automatic changelog generation for PR tgstation#61738 [ci skip]

commit b626fad
Author: Zytolg <33048583+Zytolg@users.noreply.github.com>
Date:   Tue Sep 28 18:52:10 2021 -0600

    Removes Duplicate Disposals Pipe and Glass Table from MetaENG (tgstation#61738)

    * Removes Duplicate Disposals Pipe and Glass Table from MetaENG

    * Plumbing and Power too

    Co-authored-by: Zytolg <theoriginaldash@gmail,com>

commit 87cf6e7
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Tue Sep 28 17:51:28 2021 -0700

    Automatic changelog generation for PR tgstation#61733 [ci skip]

commit 6174323
Author: esainane <esainane+github@gmail.com>
Date:   Wed Sep 29 13:51:25 2021 +1300

    Derelict: Remove duplicate APCs (tgstation#61733)

    Two APCs were fighting for control over
    `/area/ruin/space/derelict/bridge/access` at (66,80) and (63,61).
    This removes the APC at (63,61) and the two wires leading up to it.

    Two APCs were fighting for control over
    `/area/ruin/space/derelict/hallway/secondary` at (35,23) and (58,24).
    This removes the APC at (58,24), which is directly over a wire path,
    so does not require any power cables to be removed.

commit a43209f
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Tue Sep 28 17:51:11 2021 -0700

    Automatic changelog generation for PR tgstation#61735 [ci skip]

commit 9e40039
Author: Iamgoofball <iamgoofball@gmail.com>
Date:   Tue Sep 28 17:51:08 2021 -0700

    Fixes references to now dead gangs in Families objectives. (tgstation#61735)

commit 44c424f
Author: Changelogs <action@github.com>
Date:   Wed Sep 29 00:11:00 2021 +0000

    Automatic changelog compile [ci skip]

commit 9d200cb
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Tue Sep 28 17:07:45 2021 -0700

    Automatic changelog generation for PR tgstation#61532 [ci skip]

commit 65267ba
Author: Krysonism <49783092+Krysonism@users.noreply.github.com>
Date:   Wed Sep 29 02:07:41 2021 +0200

    Cytology Adjacent Update #1: New pet food, made from pets. Buffs health of selected simple mobs. (tgstation#61532)

    * doggy dog world

    * space begone

    * suggestions from review

    * removes frog related oopsie

    * indent fix

commit 67194ea
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Tue Sep 28 16:52:16 2021 -0700

    Automatic changelog generation for PR tgstation#61722 [ci skip]

commit 61c30cc
Author: Arkatos1 <43862960+Arkatos1@users.noreply.github.com>
Date:   Wed Sep 29 01:52:12 2021 +0200

    ntoscard templates fix (tgstation#61722)

commit 378da49
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Tue Sep 28 16:47:47 2021 -0700

    Automatic changelog generation for PR tgstation#61730 [ci skip]

commit 81989f0
Author: TiviPlus <57223640+TiviPlus@users.noreply.github.com>
Date:   Wed Sep 29 01:47:44 2021 +0200

    Fix baselighting not respecting changeturfs (tgstation#61730)

commit 1846c2d
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Tue Sep 28 15:03:30 2021 -0700

    Automatic changelog generation for PR tgstation#61716 [ci skip]

commit e330485
Author: Thunder12345 <Thunder12345@users.noreply.github.com>
Date:   Tue Sep 28 23:03:27 2021 +0100

    Replaces CTF hardsuits with new armoured vests (tgstation#61716)

    Co-authored-by: Thunder12345 <stewart@critar.demon.co.uk>

commit 84c7b68
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Tue Sep 28 14:21:30 2021 -0700

    Automatic changelog generation for PR tgstation#61736 [ci skip]

commit 643645b
Author: Imaginos16 <77556824+Imaginos16@users.noreply.github.com>
Date:   Tue Sep 28 18:21:27 2021 -0300

    Makes colo cup sprites actually consistent, and a small edit to a joke. (tgstation#61736)

    * Update drinks.dm

    * adds actual colo cups sprites lol im dumb

    * fixes a small sprite error

commit c1fd222
Author: John Willard <53777086+JohnFulpWillard@users.noreply.github.com>
Date:   Tue Sep 28 17:16:09 2021 -0400

    dehardcodes limb icons (tgstation#61570)

    This is a small change aimed at helping downstream modularity.
    Currently the file these sprites use are hardcoded with a define, this removes that and instead moves it to a var.

    I guess the thing is defaults should be overridable, it's just we've never ran into a case where it's needed, so adding that functionality on its own looks really weird

    annoying. I don't like adding stuff that's only useful to downstreams, for various reasons, but this seems ok after some thought. fulfills the promise of _DEFAULT.
    -Lemon

commit eec8463
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Tue Sep 28 12:45:42 2021 -0700

    Automatic changelog generation for PR tgstation#61694 [ci skip]

commit 496a768
Author: Mooshimi <85910816+Mooshimi@users.noreply.github.com>
Date:   Tue Sep 28 15:45:38 2021 -0400

    [MDB Ignore] Make shuttle windows deconstructable (tgstation#61694)

    * shuttle windows

    * refactor reinf windows

    plasma and shuttle only

    * messed up one change

    * i am actually blind

    * made and did file

commit a66ef31
Author: MrMelbert <51863163+MrMelbert@users.noreply.github.com>
Date:   Tue Sep 28 14:15:11 2021 -0500

    Corrects mapload args that sprug up in the past few days (tgstation#61759)

    See tgstation#61623 . These were either merged after the prior PR, coded before the prior PR, or were made in between and not updated.

commit 4fc5897
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Tue Sep 28 11:56:21 2021 -0700

    Automatic changelog generation for PR tgstation#61725 [ci skip]

commit 43a2b90
Author: Fikou <23585223+Fikou@users.noreply.github.com>
Date:   Tue Sep 28 20:56:17 2021 +0200

    renames enable debug verbs to enable mapping verbs (tgstation#61725)

    its such a stupid fucking name, the verbs are all mapping related, they are all in the mapping tab, nobody knows about them because its called debug verbs for some reason instead of mapping verbs

commit 4413bbc
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Tue Sep 28 08:00:07 2021 -0700

    Automatic changelog generation for PR tgstation#61724 [ci skip]

commit a23b275
Author: Mothblocks <35135081+Mothblocks@users.noreply.github.com>
Date:   Tue Sep 28 08:00:01 2021 -0700

    Fixes check AI laws collapsing, making them unreadable (tgstation#61724)

    Previously, this would be putting (x2) next to the first 3 laws, and it would look like the 2nd cyborg had no laws.

commit a62262f
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Tue Sep 28 07:58:50 2021 -0700

    Automatic changelog generation for PR tgstation#61723 [ci skip]

commit 4eee6a1
Author: Timberpoes <silent_insomnia_pp@hotmail.co.uk>
Date:   Tue Sep 28 15:58:47 2021 +0100

    Fixes contractor drop pods not being clickable due to suspected BYOND issue. (tgstation#61723)

    Fixes tgstation#61695

    When breaking the entire problem down, I identified the point in time at which the pod stopped being clickable
    Spawning in pods manually and running their various procs couldn't replicate the issue. As a result, I eliminated pod code as the root cause and focused on the pod_landingzone that control them.

    I considered the debris as a possible cause following:
    tgstation#61695

    However, removing the debris actually removed ALL clickable area for the pods. The debris overlap was the only part that let me click on the pods.

    So then I set to hacking away at any animation code. At one point I removed both the animates

    animate(pod.get_filter("motionblur"), y = 0, time = pod.delays[POD_FALLING], flags = ANIMATION_PARALLEL)
    animate(pod, pixel_z = -1 * abs(sin(rotation))*4, pixel_x = SUPPLYPOD_X_OFFSET + (sin(rotation) * 20), time = pod.delays[POD_FALLING], easing = LINEAR_EASING, flags = ANIMATION_PARALLEL) //Make the pod fall! At an angle!
    from /obj/effect/pod_landingzone/proc/beginLaunch and the problem still persisted.

    When I removed pod.add_filter("motionblur",1,list("type"="motion_blur", "x"=0, "y"=3)) after this (the effect was permanently on the pod which made it pretty obvious as a possible cause) the problem vanished entirely.

    Without the motion blur filter applied, pods now function properly.

    As a result, I believe this is a BYOND issue. Someone with more brains than me can probably work out a test case. Until someone with more brains than me comes along to fix it, removing the motion blur filter is my solution.

commit 1859df5
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Tue Sep 28 07:55:59 2021 -0700

    Automatic changelog generation for PR tgstation#61229 [ci skip]

commit 29c49fd
Author: dragomagol <66640614+dragomagol@users.noreply.github.com>
Date:   Tue Sep 28 07:55:55 2021 -0700

    Ports animated locker doors (tgstation#61229)

    ## About The Pull Request
    Ports locker door animations from Yogstation!

    yogstation13/Yogstation#9706
    Skyrat-SS13/Skyrat-tg#6767

    ## Why It's Good For The Game
    The locker opening animation is really nice, it's a shame we don't have it yet.

commit 6189b88
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Tue Sep 28 02:08:57 2021 -0700

    Automatic changelog generation for PR tgstation#61692 [ci skip]

commit df1260f
Author: CRITAWAKETS <sebastienracicot@hotmail.com>
Date:   Tue Sep 28 05:08:53 2021 -0400

    Fixes the auxiliary base construction console. (tgstation#61692)

commit c254707
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Tue Sep 28 02:05:30 2021 -0700

    Automatic changelog generation for PR tgstation#61698 [ci skip]

commit 6317b7b
Author: TiviPlus <57223640+TiviPlus@users.noreply.github.com>
Date:   Tue Sep 28 11:05:27 2021 +0200

    Fix connect loc not respecting phasing in some cases when it should (tgstation#61698)

commit 26df314
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Tue Sep 28 00:01:11 2021 -0700

    Automatic changelog generation for PR tgstation#60920 [ci skip]

commit ff41f8a
Author: twilightwanderer <88540658+twilightwanderer@users.noreply.github.com>
Date:   Tue Sep 28 10:01:07 2021 +0300

    Fixing the chat client (tgstation#60920)

    Corrects the chat restriction on using ASII characters only. (This PR was created for Skyrat-TG, but the collaborator of that repository asked me to adapt this PR for tgstation.)

    This will fix tgstation#54598
    In the original code, the chat client uses only ASII standard characters, which is very limited in its capabilities. For example, does not allow you to use specialized characters, which would have taken the atmosphere of the old messengers, as well as regional characters. The lack of regional characters complicates the game for non-English-speaking servers. For example, the Russian-speaking player community Space Station 13 The Fluffy Frontier uses the original Skyrat-tg build. And the players of this community almost do not use the chat client to communicate due to the fact that they can not use Cyrillic characters.

commit 3b275f8
Author: Sheits <81964183+Sheits@users.noreply.github.com>
Date:   Tue Sep 28 16:57:52 2021 +1000

    Creates fly.ts for the new tgui prefs menu (tgstation#61728)

    Co-authored-by: Mothblocks <35135081+Mothblocks@users.noreply.github.com>

commit 32518f6
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Mon Sep 27 22:52:08 2021 -0700

    Automatic changelog generation for PR tgstation#61715 [ci skip]

commit 76c6754
Author: Fikou <23585223+Fikou@users.noreply.github.com>
Date:   Tue Sep 28 07:52:05 2021 +0200

    secret recipes are now actually secret (tgstation#61715)

commit 67e7261
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Mon Sep 27 20:38:52 2021 -0700

    Automatic changelog generation for PR tgstation#61714 [ci skip]

commit 1f000ba
Author: Mothblocks <35135081+Mothblocks@users.noreply.github.com>
Date:   Mon Sep 27 20:38:49 2021 -0700

    Fix word bounds on filters, where they would only be applied at the beginning (tgstation#61714)

commit 563cb1d
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Mon Sep 27 19:06:06 2021 -0700

    Automatic changelog generation for PR tgstation#61607 [ci skip]

commit 744679b
Author: Zytolg <33048583+Zytolg@users.noreply.github.com>
Date:   Mon Sep 27 20:06:02 2021 -0600

    Adds brand new ruins to the Icebox Ruins roster. (tgstation#61607)

commit 69fc80f
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Mon Sep 27 17:52:00 2021 -0700

    Automatic changelog generation for PR tgstation#61680 [ci skip]

commit dbfa6c0
Author: NamelessFairy <40036527+NamelessFairy@users.noreply.github.com>
Date:   Tue Sep 28 01:51:57 2021 +0100

    Fix Genturf on Icebox (tgstation#61680)

commit a19f273
Author: Changelogs <action@github.com>
Date:   Tue Sep 28 00:11:28 2021 +0000

    Automatic changelog compile [ci skip]

commit c277a6f
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Mon Sep 27 17:08:07 2021 -0700

    Automatic changelog generation for PR tgstation#61621 [ci skip]

commit 3c5d622
Author: Ghom <42542238+Ghommie@users.noreply.github.com>
Date:   Tue Sep 28 02:08:03 2021 +0200

    You can now use backslashes as an escape character for text modification. (tgstation#61621)

commit eac67c9
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Mon Sep 27 17:04:30 2021 -0700

    Automatic changelog generation for PR tgstation#61719 [ci skip]

commit 74be623
Author: Fikou <23585223+Fikou@users.noreply.github.com>
Date:   Tue Sep 28 02:04:27 2021 +0200

    Secret Gateways: Config loaded Away Missions + Anti-observing Z level traits (tgstation#61719)

commit ca4524e
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Mon Sep 27 16:35:18 2021 -0700

    Automatic changelog generation for PR tgstation#61726 [ci skip]

commit d9ede13
Author: tralezab <40974010+tralezab@users.noreply.github.com>
Date:   Mon Sep 27 16:35:15 2021 -0700

    if you give a monkey an instrument, it will begin playing the donkey kong theme (tgstation#61726)
EOBGames added a commit to EOBGames/tgstation that referenced this pull request Sep 29, 2021
commit c10e1e6
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Tue Sep 28 20:55:39 2021 -0700

    Automatic changelog generation for PR tgstation#61746 [ci skip]

commit 9bcc80c
Author: 567Turtle <91508746+567Turtle@users.noreply.github.com>
Date:   Tue Sep 28 22:55:36 2021 -0500

    Constructable Filing Cabinets (tgstation#61746)

commit 2fd4e1d
Author: tralezab <40974010+tralezab@users.noreply.github.com>
Date:   Tue Sep 28 19:12:45 2021 -0700

    adds tralezab as a codeowner of datum ais (tgstation#61769)

commit f45fb5d
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Tue Sep 28 17:52:34 2021 -0700

    Automatic changelog generation for PR tgstation#61739 [ci skip]

commit 8473d44
Author: Zytolg <33048583+Zytolg@users.noreply.github.com>
Date:   Tue Sep 28 18:52:30 2021 -0600

    Ditches the Spare Monkey-Operated Firealarm in Kilostaiton Genetics (tgstation#61739)

    Co-authored-by: Zytolg <theoriginaldash@gmail,com>

commit e135108
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Tue Sep 28 17:52:14 2021 -0700

    Automatic changelog generation for PR tgstation#61738 [ci skip]

commit b626fad
Author: Zytolg <33048583+Zytolg@users.noreply.github.com>
Date:   Tue Sep 28 18:52:10 2021 -0600

    Removes Duplicate Disposals Pipe and Glass Table from MetaENG (tgstation#61738)

    * Removes Duplicate Disposals Pipe and Glass Table from MetaENG

    * Plumbing and Power too

    Co-authored-by: Zytolg <theoriginaldash@gmail,com>

commit 87cf6e7
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Tue Sep 28 17:51:28 2021 -0700

    Automatic changelog generation for PR tgstation#61733 [ci skip]

commit 6174323
Author: esainane <esainane+github@gmail.com>
Date:   Wed Sep 29 13:51:25 2021 +1300

    Derelict: Remove duplicate APCs (tgstation#61733)

    Two APCs were fighting for control over
    `/area/ruin/space/derelict/bridge/access` at (66,80) and (63,61).
    This removes the APC at (63,61) and the two wires leading up to it.

    Two APCs were fighting for control over
    `/area/ruin/space/derelict/hallway/secondary` at (35,23) and (58,24).
    This removes the APC at (58,24), which is directly over a wire path,
    so does not require any power cables to be removed.

commit a43209f
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Tue Sep 28 17:51:11 2021 -0700

    Automatic changelog generation for PR tgstation#61735 [ci skip]

commit 9e40039
Author: Iamgoofball <iamgoofball@gmail.com>
Date:   Tue Sep 28 17:51:08 2021 -0700

    Fixes references to now dead gangs in Families objectives. (tgstation#61735)

commit 44c424f
Author: Changelogs <action@github.com>
Date:   Wed Sep 29 00:11:00 2021 +0000

    Automatic changelog compile [ci skip]

commit 9d200cb
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Tue Sep 28 17:07:45 2021 -0700

    Automatic changelog generation for PR tgstation#61532 [ci skip]

commit 65267ba
Author: Krysonism <49783092+Krysonism@users.noreply.github.com>
Date:   Wed Sep 29 02:07:41 2021 +0200

    Cytology Adjacent Update #1: New pet food, made from pets. Buffs health of selected simple mobs. (tgstation#61532)

    * doggy dog world

    * space begone

    * suggestions from review

    * removes frog related oopsie

    * indent fix

commit 67194ea
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Tue Sep 28 16:52:16 2021 -0700

    Automatic changelog generation for PR tgstation#61722 [ci skip]

commit 61c30cc
Author: Arkatos1 <43862960+Arkatos1@users.noreply.github.com>
Date:   Wed Sep 29 01:52:12 2021 +0200

    ntoscard templates fix (tgstation#61722)

commit 378da49
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Tue Sep 28 16:47:47 2021 -0700

    Automatic changelog generation for PR tgstation#61730 [ci skip]

commit 81989f0
Author: TiviPlus <57223640+TiviPlus@users.noreply.github.com>
Date:   Wed Sep 29 01:47:44 2021 +0200

    Fix baselighting not respecting changeturfs (tgstation#61730)

commit 1846c2d
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Tue Sep 28 15:03:30 2021 -0700

    Automatic changelog generation for PR tgstation#61716 [ci skip]

commit e330485
Author: Thunder12345 <Thunder12345@users.noreply.github.com>
Date:   Tue Sep 28 23:03:27 2021 +0100

    Replaces CTF hardsuits with new armoured vests (tgstation#61716)

    Co-authored-by: Thunder12345 <stewart@critar.demon.co.uk>

commit 84c7b68
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Tue Sep 28 14:21:30 2021 -0700

    Automatic changelog generation for PR tgstation#61736 [ci skip]

commit 643645b
Author: Imaginos16 <77556824+Imaginos16@users.noreply.github.com>
Date:   Tue Sep 28 18:21:27 2021 -0300

    Makes colo cup sprites actually consistent, and a small edit to a joke. (tgstation#61736)

    * Update drinks.dm

    * adds actual colo cups sprites lol im dumb

    * fixes a small sprite error

commit c1fd222
Author: John Willard <53777086+JohnFulpWillard@users.noreply.github.com>
Date:   Tue Sep 28 17:16:09 2021 -0400

    dehardcodes limb icons (tgstation#61570)

    This is a small change aimed at helping downstream modularity.
    Currently the file these sprites use are hardcoded with a define, this removes that and instead moves it to a var.

    I guess the thing is defaults should be overridable, it's just we've never ran into a case where it's needed, so adding that functionality on its own looks really weird

    annoying. I don't like adding stuff that's only useful to downstreams, for various reasons, but this seems ok after some thought. fulfills the promise of _DEFAULT.
    -Lemon

commit eec8463
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Tue Sep 28 12:45:42 2021 -0700

    Automatic changelog generation for PR tgstation#61694 [ci skip]

commit 496a768
Author: Mooshimi <85910816+Mooshimi@users.noreply.github.com>
Date:   Tue Sep 28 15:45:38 2021 -0400

    [MDB Ignore] Make shuttle windows deconstructable (tgstation#61694)

    * shuttle windows

    * refactor reinf windows

    plasma and shuttle only

    * messed up one change

    * i am actually blind

    * made and did file

commit a66ef31
Author: MrMelbert <51863163+MrMelbert@users.noreply.github.com>
Date:   Tue Sep 28 14:15:11 2021 -0500

    Corrects mapload args that sprug up in the past few days (tgstation#61759)

    See tgstation#61623 . These were either merged after the prior PR, coded before the prior PR, or were made in between and not updated.

commit 4fc5897
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Tue Sep 28 11:56:21 2021 -0700

    Automatic changelog generation for PR tgstation#61725 [ci skip]

commit 43a2b90
Author: Fikou <23585223+Fikou@users.noreply.github.com>
Date:   Tue Sep 28 20:56:17 2021 +0200

    renames enable debug verbs to enable mapping verbs (tgstation#61725)

    its such a stupid fucking name, the verbs are all mapping related, they are all in the mapping tab, nobody knows about them because its called debug verbs for some reason instead of mapping verbs

commit 4413bbc
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Tue Sep 28 08:00:07 2021 -0700

    Automatic changelog generation for PR tgstation#61724 [ci skip]

commit a23b275
Author: Mothblocks <35135081+Mothblocks@users.noreply.github.com>
Date:   Tue Sep 28 08:00:01 2021 -0700

    Fixes check AI laws collapsing, making them unreadable (tgstation#61724)

    Previously, this would be putting (x2) next to the first 3 laws, and it would look like the 2nd cyborg had no laws.

commit a62262f
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Tue Sep 28 07:58:50 2021 -0700

    Automatic changelog generation for PR tgstation#61723 [ci skip]

commit 4eee6a1
Author: Timberpoes <silent_insomnia_pp@hotmail.co.uk>
Date:   Tue Sep 28 15:58:47 2021 +0100

    Fixes contractor drop pods not being clickable due to suspected BYOND issue. (tgstation#61723)

    Fixes tgstation#61695

    When breaking the entire problem down, I identified the point in time at which the pod stopped being clickable
    Spawning in pods manually and running their various procs couldn't replicate the issue. As a result, I eliminated pod code as the root cause and focused on the pod_landingzone that control them.

    I considered the debris as a possible cause following:
    tgstation#61695

    However, removing the debris actually removed ALL clickable area for the pods. The debris overlap was the only part that let me click on the pods.

    So then I set to hacking away at any animation code. At one point I removed both the animates

    animate(pod.get_filter("motionblur"), y = 0, time = pod.delays[POD_FALLING], flags = ANIMATION_PARALLEL)
    animate(pod, pixel_z = -1 * abs(sin(rotation))*4, pixel_x = SUPPLYPOD_X_OFFSET + (sin(rotation) * 20), time = pod.delays[POD_FALLING], easing = LINEAR_EASING, flags = ANIMATION_PARALLEL) //Make the pod fall! At an angle!
    from /obj/effect/pod_landingzone/proc/beginLaunch and the problem still persisted.

    When I removed pod.add_filter("motionblur",1,list("type"="motion_blur", "x"=0, "y"=3)) after this (the effect was permanently on the pod which made it pretty obvious as a possible cause) the problem vanished entirely.

    Without the motion blur filter applied, pods now function properly.

    As a result, I believe this is a BYOND issue. Someone with more brains than me can probably work out a test case. Until someone with more brains than me comes along to fix it, removing the motion blur filter is my solution.

commit 1859df5
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Tue Sep 28 07:55:59 2021 -0700

    Automatic changelog generation for PR tgstation#61229 [ci skip]

commit 29c49fd
Author: dragomagol <66640614+dragomagol@users.noreply.github.com>
Date:   Tue Sep 28 07:55:55 2021 -0700

    Ports animated locker doors (tgstation#61229)

    ## About The Pull Request
    Ports locker door animations from Yogstation!

    yogstation13/Yogstation#9706
    Skyrat-SS13/Skyrat-tg#6767

    ## Why It's Good For The Game
    The locker opening animation is really nice, it's a shame we don't have it yet.

commit 6189b88
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Tue Sep 28 02:08:57 2021 -0700

    Automatic changelog generation for PR tgstation#61692 [ci skip]

commit df1260f
Author: CRITAWAKETS <sebastienracicot@hotmail.com>
Date:   Tue Sep 28 05:08:53 2021 -0400

    Fixes the auxiliary base construction console. (tgstation#61692)

commit c254707
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Tue Sep 28 02:05:30 2021 -0700

    Automatic changelog generation for PR tgstation#61698 [ci skip]

commit 6317b7b
Author: TiviPlus <57223640+TiviPlus@users.noreply.github.com>
Date:   Tue Sep 28 11:05:27 2021 +0200

    Fix connect loc not respecting phasing in some cases when it should (tgstation#61698)

commit 26df314
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Tue Sep 28 00:01:11 2021 -0700

    Automatic changelog generation for PR tgstation#60920 [ci skip]

commit ff41f8a
Author: twilightwanderer <88540658+twilightwanderer@users.noreply.github.com>
Date:   Tue Sep 28 10:01:07 2021 +0300

    Fixing the chat client (tgstation#60920)

    Corrects the chat restriction on using ASII characters only. (This PR was created for Skyrat-TG, but the collaborator of that repository asked me to adapt this PR for tgstation.)

    This will fix tgstation#54598
    In the original code, the chat client uses only ASII standard characters, which is very limited in its capabilities. For example, does not allow you to use specialized characters, which would have taken the atmosphere of the old messengers, as well as regional characters. The lack of regional characters complicates the game for non-English-speaking servers. For example, the Russian-speaking player community Space Station 13 The Fluffy Frontier uses the original Skyrat-tg build. And the players of this community almost do not use the chat client to communicate due to the fact that they can not use Cyrillic characters.

commit 3b275f8
Author: Sheits <81964183+Sheits@users.noreply.github.com>
Date:   Tue Sep 28 16:57:52 2021 +1000

    Creates fly.ts for the new tgui prefs menu (tgstation#61728)

    Co-authored-by: Mothblocks <35135081+Mothblocks@users.noreply.github.com>

commit 32518f6
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Mon Sep 27 22:52:08 2021 -0700

    Automatic changelog generation for PR tgstation#61715 [ci skip]

commit 76c6754
Author: Fikou <23585223+Fikou@users.noreply.github.com>
Date:   Tue Sep 28 07:52:05 2021 +0200

    secret recipes are now actually secret (tgstation#61715)

commit 67e7261
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Mon Sep 27 20:38:52 2021 -0700

    Automatic changelog generation for PR tgstation#61714 [ci skip]

commit 1f000ba
Author: Mothblocks <35135081+Mothblocks@users.noreply.github.com>
Date:   Mon Sep 27 20:38:49 2021 -0700

    Fix word bounds on filters, where they would only be applied at the beginning (tgstation#61714)

commit 563cb1d
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Mon Sep 27 19:06:06 2021 -0700

    Automatic changelog generation for PR tgstation#61607 [ci skip]

commit 744679b
Author: Zytolg <33048583+Zytolg@users.noreply.github.com>
Date:   Mon Sep 27 20:06:02 2021 -0600

    Adds brand new ruins to the Icebox Ruins roster. (tgstation#61607)

commit 69fc80f
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Mon Sep 27 17:52:00 2021 -0700

    Automatic changelog generation for PR tgstation#61680 [ci skip]

commit dbfa6c0
Author: NamelessFairy <40036527+NamelessFairy@users.noreply.github.com>
Date:   Tue Sep 28 01:51:57 2021 +0100

    Fix Genturf on Icebox (tgstation#61680)

commit a19f273
Author: Changelogs <action@github.com>
Date:   Tue Sep 28 00:11:28 2021 +0000

    Automatic changelog compile [ci skip]

commit c277a6f
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Mon Sep 27 17:08:07 2021 -0700

    Automatic changelog generation for PR tgstation#61621 [ci skip]

commit 3c5d622
Author: Ghom <42542238+Ghommie@users.noreply.github.com>
Date:   Tue Sep 28 02:08:03 2021 +0200

    You can now use backslashes as an escape character for text modification. (tgstation#61621)

commit eac67c9
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Mon Sep 27 17:04:30 2021 -0700

    Automatic changelog generation for PR tgstation#61719 [ci skip]

commit 74be623
Author: Fikou <23585223+Fikou@users.noreply.github.com>
Date:   Tue Sep 28 02:04:27 2021 +0200

    Secret Gateways: Config loaded Away Missions + Anti-observing Z level traits (tgstation#61719)

commit ca4524e
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Mon Sep 27 16:35:18 2021 -0700

    Automatic changelog generation for PR tgstation#61726 [ci skip]

commit d9ede13
Author: tralezab <40974010+tralezab@users.noreply.github.com>
Date:   Mon Sep 27 16:35:15 2021 -0700

    if you give a monkey an instrument, it will begin playing the donkey kong theme (tgstation#61726)
@adamkad1
Copy link

adamkad1 commented Oct 4, 2021

What is this, goonstation?

@Mothblocks
Copy link
Member

no sir you are on the tgstation repo. https://github.com/goonstation/goonstation <-- this is goonstation

LemonInTheDark pushed a commit to LemonInTheDark/tgstation that referenced this pull request Dec 12, 2021
…g Z level traits (tgstation#858)

* Secret Gateways: Config loaded Away Missions + Anti-observing Z level traits (tgstation#61719)

* Secret Gateways: Config loaded Away Missions + Anti-observing Z level traits

Co-authored-by: Fikou <23585223+Fikou@users.noreply.github.com>
@Fikou Fikou deleted the secret-gateways branch January 9, 2022 02:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Config Update Time to bother the headadmins for three months to get your config applied Feature Exposes new bugs in interesting ways
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet