Ports SSnetworks killings #22104
Merged
Ports SSnetworks killings #22104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ToasterBiome
approved these changes
May 31, 2024
Yogbot-13
added a commit
that referenced
this pull request
May 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Document the changes in your pull request
Was asked if I can finish #21789
This PR kills SSnetworks, adds SSmodular_computers, reorganizes NTNet Downloader, removes peer-to-peer and systemcontrol apps (never used)
This one is a little smaller in scope as it isn't implementing the program flags nor removing computer parts, but I think some people here wanted to keep it? So I'm not really gonna touch it for now.
Why is this good for the game?
Removes bad systems that will never be used ever and were wasteful, adds more modularized alternative that also has the benefit of making TG ports easier. Also I think the NTNet store is sorta better? I dunno you be the judge.
Testing
I opened a local server and opened my tablet phone, tried PDA'ing, used store manager, tried a few other apps, works fine, even checked wirecarp.
Also used RD's door remote on its office airlock in all 3 modes.
Changelog
馃啈 wonderinghost, JohnFulpWillard
experimental: Reworked NTNet Downloader and backend modpc/airlock remote stuff.
/:cl: