Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added resolve-arg function in selmer.parser which lets you resolve args passed to the handler of custom tags as per request: https://github.com/yogthos/Selmer/issues/303 #304

Merged
merged 1 commit into from
Jul 6, 2023

Conversation

didibus
Copy link
Contributor

@didibus didibus commented Jul 6, 2023

I added resolve-arg to the selmer.parser namespace, let me know if you think it be better to put it in another one.

I've also followed stuart sierra's advice of not having a function that maps and having one for a single element where it's trivial
for users to map over it.

I added to the README how to use it.

I have 3 failing tests on my machine, but they are all for date filter, when using Locale zh, I get some chinese characters as part
of the output, and the time is 12:00 instead of 00:00. Anyways, I did not bother debugging them, since they are clearly unrelated to
my changes.

I did not update the changelog, I think you might want to do that when cutting a new release?

Regards

passed to the handler of custom tags as per request:
#303
@yogthos
Copy link
Owner

yogthos commented Jul 6, 2023

Fantastic, and I think selmer.parser is as good a place as any. And looks like those tests might be JVM version dependent because the formatter behavior changed at one point. All tests pass on my machine, so I think we're ok there. :)

And just cut a new release 1.12.59 with the update! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants