Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possibility to use custom font-family. #21

Closed
jarey opened this issue Oct 4, 2021 · 3 comments
Closed

Possibility to use custom font-family. #21

jarey opened this issue Oct 4, 2021 · 3 comments

Comments

@jarey
Copy link

jarey commented Oct 4, 2021

Hello @yogthos, and once again thanks for this awesome library.

I was wondering if it would be possible to add support to specifying custom font-family in order to be used by the library.

The documentation illustrates that only certain font families are supported; ¿would it be possible to add support?

We would happily contribute if you can give a piece of advice on how to approach the change if needed.

Thanks in advance.

Kind regards.

@jarey
Copy link
Author

jarey commented Oct 4, 2021

As seen in clj-pdf, could be possible to expose custom font-family configuration attributes in json-to-pdf?

https://github.com/clj-pdf/clj-pdf#using-custom-ttf-fonts

Thanks again.

@jarey
Copy link
Author

jarey commented Oct 4, 2021

Double-checked the documentation on clj-pdf and tested if the json-to-pdf java wrapper executed OK with the ttf-name, undocumented for the wrapper.

Result was ok, so support is already provided.

Closing this issue, thanks one again.

@yogthos, if you want a pullt request with a documentation update for this part, would gladly elaborate one for the readme.md; just let me know.

@jarey jarey closed this as completed Oct 4, 2021
@yogthos
Copy link
Owner

yogthos commented Oct 4, 2021

@jarey a PR for updated docs would be greatly appreciated :)

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants