Quote filename in Content-Disposition (bug 540028)

yohanboniface · Sep 9, 2014 · 43137c5 · 43137c5
1 parent acc8787
commit 43137c5
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/apps/versions/views.py b/apps/versions/views.py
@@ -129,7 +129,7 @@ def download_source(request, version_id):
                                    viewer=True, ignore_disabled=True)
          or acl.action_allowed(request, 'Editors', 'BinarySource'))):
         res = HttpResponseSendFile(request, version.source.path)
-        name = os.path.basename(version.source.path)
-        res['Content-Disposition'] = "attachment; filename={0}".format(name)
+        name = os.path.basename(version.source.path.replace('"', ''))
+        res['Content-Disposition'] = 'attachment; filename="{0}"'.format(name)
         return res
     raise http.Http404()