Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Added python publishing #358

Merged
merged 6 commits into from
Mar 12, 2024
Merged

feat: Added python publishing #358

merged 6 commits into from
Mar 12, 2024

Conversation

carstencodes
Copy link
Contributor

  • Added binary distribution folder for PY
  • Added scripts to build python binary wheel package
  • Added new configuration source: Python pyproject.toml for Python
  • Added CI Pipeline for publishing Wheel packages after goreleaser job/workflow has finished
    • NOTE A secret called PYPI_USERNAME (usually token) and PYPI_AUTH_TOKEN (usually a token from pypi) must be provided by @yoheimuta to upload the package to pypi.org

Closes #338

@carstencodes
feat: Added ability to parse toml files
f22f0a7 
In yoheimuta#338 the distribution of python wheels is requested.

Python relies according to PEP 518 on pyproject.toml
allowing to add a [tools] table with all config values.

The pyproject.toml can now be added as a valid project
configuration source.
@carstencodes
feat: Added setup py that builds wheel files manually
a040b98 
The wheel file is build manually using a python script.
Most bundlers cannot use different platforms for python tags
@carstencodes
doc: Added documentation for python support
7f5019c 
In yoheimuta#338 Python support is requested. Documentation has been added.
@carstencodes
doc: Added publisher
463d5e8 
In yoheimuta#338 Python support is requested. This upload step
should perform the upload step
@carstencodes
ci: Binaries must be created
ee48052 
The binaries must be created before the wheels are created.

This is done by goreleaser build in this case
@carstencodes carstencodes changed the title Contrib/carstencodes/deployments/python feat: Added python publishing Dec 18, 2023
@carstencodes
chore: fix line-length
0688b8a 
Line-length of YAML was exceeded
@carstencodes carstencodes deleted the contrib/carstencodes/deployments/python branch December 23, 2023 08:13
@carstencodes carstencodes restored the contrib/carstencodes/deployments/python branch December 23, 2023 08:23
@carstencodes carstencodes reopened this Dec 23, 2023
yoheimuta
yoheimuta approved these changes Mar 9, 2024
View reviewed changes
Copy link
Owner

@yoheimuta yoheimuta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your excellent contribution!
Sorry for the late response 🙇‍♂️

I'm dealing with PYPY setup later.

@carstencodes
Copy link
Contributor Author

You're welcome. I think I will start on #337 soon.

@yoheimuta
Copy link
Owner

A secret called PYPI_USERNAME (usually token) and PYPI_AUTH_TOKEN (usually a token from pypi) must be provided

I added these secrets to Actions secrets.

image

@yoheimuta yoheimuta merged commit 0d75656 into yoheimuta:master Mar 12, 2024
11 checks passed
@yoheimuta
Copy link
Owner

@carstencodes The Publish Wheel Package action was successful, but the publishing step was skipped. Is there something off with the condition?

@carstencodes carstencodes deleted the contrib/carstencodes/deployments/python branch March 13, 2024 19:22
@carstencodes
Copy link
Contributor Author

@yoheimuta Yeah, gorramn copy&paste error. cf. to #370

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yoheimuta yoheimuta yoheimuta approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Distribution] Add support for Python
2 participants
@carstencodes @yoheimuta