Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add filters to services and service accounts #145

Closed
yonahd opened this issue Nov 12, 2023 · 1 comment · Fixed by #148
Closed

Add filters to services and service accounts #145

yonahd opened this issue Nov 12, 2023 · 1 comment · Fixed by #148

Comments

@yonahd
Copy link
Owner

yonahd commented Nov 12, 2023

We are missing HasExcludedLabel and HasIncludedAge checks on services and serviceaccounts resources.

Add these checks.
@yonahd
Copy link
Owner Author

yonahd commented Nov 12, 2023

@Azhovan Would you like to complete this?

yonahd added a commit that referenced this issue Nov 13, 2023
@yonahd
chore: add missing filters to service and SA
5da6aa3 
Fixes #145
@yonahd yonahd mentioned this issue Nov 13, 2023
Merged
yonahd added a commit that referenced this issue Nov 13, 2023
@yonahd
chore: add missing filters to service and SA
ee8381b 
Fixes #145
yonahd added a commit that referenced this issue Nov 13, 2023
@yonahd
chore: add missing filters to service and SA (#148)
c996b22 
* chore: add missing filters to service and SA
Fixes #145

* chore: add missing filters to service and SA
Fixes #145
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: add missing filters to service and SA yonahd/kor
1 participant
@yonahd