Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add missing filters to service and SA #148

Merged
merged 3 commits into from Nov 13, 2023
Merged

Conversation

yonahd
Copy link
Owner

@yonahd yonahd commented Nov 13, 2023

Fixes #145

@codecov-commenter
Copy link

Codecov Report

Attention: 16 lines in your changes are missing coverage. Please review.

Comparison is base (2299588) 48.06% compared to head (0e94a1c) 47.85%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #148      +/-   ##
==========================================
- Coverage   48.06%   47.85%   -0.22%     
==========================================
  Files          20       20              
  Lines        1783     1791       +8     
==========================================
  Hits          857      857              
- Misses        785      789       +4     
- Partials      141      145       +4     
Files Coverage Δ
pkg/kor/multi.go 0.00% <0.00%> (ø)
pkg/kor/serviceaccounts.go 62.09% <55.55%> (-2.07%) ⬇️
pkg/kor/services.go 56.00% <42.85%> (-4.87%) ⬇️
pkg/kor/all.go 0.00% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yonahd yonahd merged commit c996b22 into main Nov 13, 2023
1 check passed
@yonahd yonahd deleted the add_missing_filters branch November 13, 2023 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add filters to services and service accounts
2 participants