Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crd Readme and multi support #144

Merged
merged 3 commits into from
Nov 12, 2023
Merged

Crd Readme and multi support #144

merged 3 commits into from
Nov 12, 2023

Conversation

yonahd
Copy link
Owner

@yonahd yonahd commented Nov 12, 2023

No description provided.

@codecov-commenter
Copy link

Codecov Report

Attention: 28 lines in your changes are missing coverage. Please review.

Comparison is base (05d8488) 48.23% compared to head (58c2cb6) 47.55%.
Report is 1 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #144      +/-   ##
==========================================
- Coverage   48.23%   47.55%   -0.68%     
==========================================
  Files          20       20              
  Lines        1754     1779      +25     
==========================================
  Hits          846      846              
- Misses        768      793      +25     
  Partials      140      140              
Files Coverage Δ
pkg/kor/multi.go 0.00% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@luisdavim luisdavim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yonahd yonahd merged commit dec8161 into main Nov 12, 2023
1 check passed
@yonahd yonahd deleted the crd_readme branch November 12, 2023 17:35
slimm609 pushed a commit to slimm609/kor that referenced this pull request Nov 13, 2023
* add crd to readme and support multi

* support crds in multi command
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants