Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix output for yaml and json, banner #149

Merged
merged 1 commit into from Nov 13, 2023

Conversation

slimm609
Copy link
Contributor

  • fix ouput for yaml and json with verbose
  • do not show banner on yaml or json

- fix ouput for yaml and json with verbose
- do not show banner on yaml or json
@codecov-commenter
Copy link

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (2299588) 48.06% compared to head (37e12d3) 48.16%.
Report is 1 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #149      +/-   ##
==========================================
+ Coverage   48.06%   48.16%   +0.10%     
==========================================
  Files          20       20              
  Lines        1783     1802      +19     
==========================================
+ Hits          857      868      +11     
- Misses        785      789       +4     
- Partials      141      145       +4     
Files Coverage Δ
pkg/kor/confimgmaps.go 67.21% <100.00%> (+0.27%) ⬆️
pkg/kor/deployments.go 56.00% <100.00%> (+0.89%) ⬆️
pkg/kor/hpas.go 50.56% <100.00%> (+0.56%) ⬆️
pkg/kor/ingresses.go 61.05% <100.00%> (+0.41%) ⬆️
pkg/kor/pdbs.go 52.30% <100.00%> (+0.74%) ⬆️
pkg/kor/pvc.go 56.06% <100.00%> (+0.67%) ⬆️
pkg/kor/roles.go 59.21% <100.00%> (+0.54%) ⬆️
pkg/kor/secrets.go 70.16% <100.00%> (+0.24%) ⬆️
pkg/kor/statefulsets.go 60.00% <100.00%> (+0.81%) ⬆️
pkg/kor/serviceaccounts.go 62.40% <33.33%> (-1.77%) ⬇️
... and 2 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Owner

@yonahd yonahd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yonahd yonahd merged commit 6e20381 into yonahd:main Nov 13, 2023
1 check passed
@yonahd yonahd linked an issue Nov 13, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Banner blocks parsing the json or yaml output
3 participants