fix(formatOutput): fix spacing between tables #269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #269 +/- ##
==========================================
+ Coverage 40.83% 40.87% +0.04%
==========================================
Files 58 58
Lines 2902 2899 -3
==========================================
Hits 1185 1185
+ Misses 1531 1528 -3
Partials 186 186 ☔ View full report in Codecov by Sentry. |
yonahd
reviewed
May 19, 2024
There was a problem hiding this comment.
Not sure I was clear with the issue.
I want the output like this
Unused Serviceaccounts in Namespace: default
+---+---------------------+
| # | RESOURCE NAME |
+---+---------------------+
| 1 | my-service-account |
| 2 | my-service-account2 |
+---+---------------------+
Unused Serviceaccounts in Namespace: test
+---+---------------------+
| # | RESOURCE NAME |
+---+---------------------+
| 1 | my-service-account2 |
+---+---------------------+
With the space between each namespace
added 2 commits
May 19, 2024 10:07
yonahd
pushed a commit
that referenced
this pull request
Jun 10, 2024
* fix(formatOutput): fix spacing between tables (#269) * fix(formatOutput): fix spacing between tables * fix * refactor * refactor --------- Co-authored-by: Phil Brocker <phil.brocker@gmail.com> * feat: added file sorting to makefile * fix: sorted exception files * feat: converted script in actions to make command * fix: better way to find unsorted files using makefile * fix: reverted back to bash * fix: added help print * fix: sorted via sort-exception-files * fix: using vars * fix: typo * fix: removed bin --------- Co-authored-by: Phil Brocker <5331286+pbr0ck3r@users.noreply.github.com> Co-authored-by: Phil Brocker <phil.brocker@gmail.com>
yonahd
pushed a commit
that referenced
this pull request
Jun 15, 2024
* fix(formatOutput): fix spacing between tables (#269) * fix(formatOutput): fix spacing between tables * fix * refactor * refactor --------- Co-authored-by: Phil Brocker <phil.brocker@gmail.com> * feat: added regex support * feat: updated exceptions to regex * fix: converted all existing exceptions to be regex compatible * fix: added support for configmaps and serviceaccounts * fix: Configmaps and serviceaccounts are now filtered using the same methods * fix: exceptiontype * fix: once again wrong file * feat: add K3S exceptions (#270) * feat: added clusterroles * feat: added k3s configmaps * feat: added k3s crds * feat: added k3s secrets * feat: added k3s StorageClass * feat: added job resource exceptions * feat: added job exceptions * fix: importing embed * fix: fixed sa test * fix: regex-ified job exceptions * fix: fixed resource exception for jobs * fix: removed kube-root-ca from test * fix: removed default from TestRetrieveUsedSA * fix: added regex flag to jsons * added MatchRegex flag * sorted all exceptoins * fix: wrong regex expressions * feat: added resource exception test * fix: removed binary --------- Co-authored-by: Phil Brocker <5331286+pbr0ck3r@users.noreply.github.com> Co-authored-by: Phil Brocker <phil.brocker@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please read CONTRIBUTING.md for additional information on contributing to this repository!
What this PR does / why we need it
PR Checklist
Github Issue
[XX-XX]
Notes for your reviewers