Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: exception sorting as makefile targets #298

Merged
merged 12 commits into from
Jun 10, 2024

Conversation

Itaykal
Copy link
Contributor

@Itaykal Itaykal commented Jun 7, 2024

What this PR does / why we need it?

This PR adds two Makefile targets, one for validating the exception files' sorting, and the other to sort them recursively.
I took the code added in #295 and converted it to targets, thus simplifying both the Github action and the developer's workflow.

PR Checklist

  • This PR adds K8s exceptions (false positives)
  • This PR adds new code
  • This PR includes tests for new/existing code
  • This PR adds docs

GitHub Issue

[XX-XX]

Notes for your reviewers

@Itaykal Itaykal changed the title Feat/makefile sort exceptions Feature: exception sorting as makefile targets Jun 7, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jun 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 40.92%. Comparing base (5b9c270) to head (1081d30).
Report is 6 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #298      +/-   ##
==========================================
- Coverage   40.96%   40.92%   -0.05%     
==========================================
  Files          58       58              
  Lines        2910     2913       +3     
==========================================
  Hits         1192     1192              
- Misses       1530     1532       +2     
- Partials      188      189       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

kor Outdated Show resolved Hide resolved
Copy link
Owner

@yonahd yonahd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!
LGTM

@yonahd yonahd merged commit 1cb3c95 into yonahd:main Jun 10, 2024
1 check passed
@Itaykal Itaykal deleted the feat/makefile-sort-exceptions branch June 10, 2024 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants