-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: exception sorting as makefile targets #298
Conversation
* fix(formatOutput): fix spacing between tables * fix * refactor * refactor --------- Co-authored-by: Phil Brocker <phil.brocker@gmail.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #298 +/- ##
==========================================
- Coverage 40.96% 40.92% -0.05%
==========================================
Files 58 58
Lines 2910 2913 +3
==========================================
Hits 1192 1192
- Misses 1530 1532 +2
- Partials 188 189 +1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
LGTM
What this PR does / why we need it?
This PR adds two Makefile targets, one for validating the exception files' sorting, and the other to sort them recursively.
I took the code added in #295 and converted it to targets, thus simplifying both the Github action and the developer's workflow.
PR Checklist
GitHub Issue
[XX-XX]
Notes for your reviewers