Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(charts): run helm-docs #280

Merged
merged 1 commit into from
May 22, 2024
Merged

chore(charts): run helm-docs #280

merged 1 commit into from
May 22, 2024

Conversation

matazr
Copy link
Contributor

@matazr matazr commented May 22, 2024

fixing chart's readme based on #265 (comment)

Signed-off-by: Mahdi <mahdi.azari@debijenkorf.nl>
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 40.84%. Comparing base (710239d) to head (b90234c).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #280   +/-   ##
=======================================
  Coverage   40.84%   40.84%           
=======================================
  Files          58       58           
  Lines        2904     2904           
=======================================
  Hits         1186     1186           
  Misses       1530     1530           
  Partials      188      188           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@doronkg doronkg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
We should consider adding helm-docs as a GitHub action to update the README.md seamlessly when modifying values.yaml.

@yonahd yonahd merged commit d322899 into yonahd:main May 22, 2024
1 check passed
@matazr
Copy link
Contributor Author

matazr commented May 22, 2024

LGTM We should consider adding helm-docs as a GitHub action to update the README.md seamlessly when modifying values.yaml.

I think for any changes to charts could be also appVersion in chart.yaml

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants