add --exclude-namespace

[linrl3]

To solve #29

[linrl3]

@yonahd Take a look when you have time. Thanks!

[yonahd]

@yonahd Take a look when you have time. Thanks!

Hopefully over the weekend I'll get to it.

[linrl3]

I will fix these in next few days.

[linrl3]

@yonahd Please review again, thanks!

[yonahd]

Looks good.
2 small comments

[yonahd]

I suggest something like this

func SetNamespaceList(kubeClient *kubernetes.Clientset) []string {

	namespaces := make([]string, 0)

	includeNamespaceMap := make(map[string]struct{})
	excludeNamespaceMap := make(map[string]struct{})
	includeNamespaces := strings.Split(namespaceLists.IncludeListStr, ",")
	excludeNamespaces := strings.Split(namespaceLists.ExcludeListStr, ",")
	for _, ns := range excludeNamespaces {
		excludeNamespaceMap[ns] = struct{}{}
	}
	for _, ns := range includeNamespaces {
		includeNamespaceMap[ns] = struct{}{}
	}
	namespaceList, err := kubeClient.CoreV1().Namespaces().List(context.TODO(), metav1.ListOptions{})
	if err != nil {
		fmt.Fprintf(os.Stderr, "Failed to retrieve namespaces: %v\n", err)
		os.Exit(1)
	}

	if includeNamespaces[0] == "" {
		if excludeNamespaces[0] != "" {
			for _, ns := range namespaceList.Items {
				if _, exists := excludeNamespaceMap[ns.Name]; !exists {
					namespaces = append(namespaces, ns.Name)
				}
			}
			return namespaces
		}
		for _, ns := range namespaceList.Items {
			namespaces = append(namespaces, ns.Name)
		}
		return namespaces
	}

	if includeNamespaces[0] != "" {
		fmt.Printf("Exclude namespaces can't be used together with include namespaces. Ignoring exclude flag\n")
	}

	namespaceExists := false
	for includeNamespace := range includeNamespaceMap {
		namespaceExists = false
		for _, ns := range namespaceList.Items {
			if ns.Name == includeNamespace {
				namespaces = append(namespaces, ns.Name)
				namespaceExists = true
				break
			}
		}
		if !namespaceExists {
			fmt.Printf("Namespace '%s' from include list doesn't exist\n", includeNamespace)
		}
	}

	return namespaces
}

[yonahd]

Hey @linrl3
Will you have time to finish this over the weekend?

[linrl3]

Hey @linrl3 Will you have time to finish this over the weekend?

Yes. I've been busy in the past few days. I think I can write some code on the weekend.

[linrl3]

I think we should keep func SetNamespaceList(namespaceLists IncludeExcludeLists, kubeClient *kubernetes.Clientset) instead of func SetNamespaceList(kubeClient *kubernetes.Clientset).
The second one will use variables outside the function.

@yonahd How do you think?

[yonahd]

I think we should keep func SetNamespaceList(namespaceLists IncludeExcludeLists, kubeClient *kubernetes.Clientset) instead of func SetNamespaceList(kubeClient *kubernetes.Clientset). The second one will use variables outside the function.

@yonahd How do you think?

Yeah. It's my mistake in the declaration.

[linrl3]

Please have look when you are free @yonahd .

I push again to:

• resolve conflicts
• modify code on the suggestions in previous comments

I just run kor and get some output here:

 ./kor all -n ns1,ns2,default
namespace [ns1] not found
namespace [ns2] not found
Failed to get ingresses namespace default: the server could not find the requested resource
Unused Resources in Namespace: default
+---+---------------+---------------+
| # | RESOURCE TYPE | RESOURCE NAME |
+---+---------------+---------------+
+---+---------------+---------------+


 ./kor all -n ns1,ns2,default -e ns3
Exclude namespaces can't be used together with include namespaces. Ignoring --exclude-namespace(-e) flag
namespace [ns1] not found
namespace [ns2] not found
Failed to get ingresses namespace default: the server could not find the requested resource
Unused Resources in Namespace: default
+---+---------------+---------------+
| # | RESOURCE TYPE | RESOURCE NAME |
+---+---------------+---------------+
+---+---------------+---------------+


 ./kor all  -e default
Failed to get ingresses namespace kube-node-lease: the server could not find the requested resource
Unused Resources in Namespace: kube-node-lease
+---+---------------+---------------+
| # | RESOURCE TYPE | RESOURCE NAME |
+---+---------------+---------------+
+---+---------------+---------------+


Failed to get ingresses namespace kube-public: the server could not find the requested resource
Unused Resources in Namespace: kube-public
+---+---------------+---------------+
| # | RESOURCE TYPE | RESOURCE NAME |
+---+---------------+---------------+
| 1 | ConfigMap     | cluster-info  |
+---+---------------+---------------+


Failed to get ingresses namespace kube-system: the server could not find the requested resource
Unused Resources in Namespace: kube-system
+---+---------------+------------------------------------+
| # | RESOURCE TYPE |           RESOURCE NAME            |
+---+---------------+------------------------------------+
| 1 | ConfigMap     | extension-apiserver-authentication |
| 2 | ConfigMap     | kubeadm-config                     |
| 3 | ConfigMap     | kubelet-config-1.20                |
+---+---------------+------------------------------------+

[yonahd]

LGTM