-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add OpenShift exceptions #311
Conversation
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #311 +/- ##
==========================================
- Coverage 41.38% 41.30% -0.09%
==========================================
Files 61 61
Lines 3204 3220 +16
==========================================
+ Hits 1326 1330 +4
- Misses 1668 1674 +6
- Partials 210 216 +6 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple small comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm
What this PR does / why we need it
This PR excludes the default resources created in basic OpenShift installations.
In addition, I've moved the config load out of the processing loop in most resource types, to reduce excessive iterations.
PR Checklist
GitHub Issue
Closes #240
Notes for your reviewers
In
pkg/kor/secrets.go
, a new exception secret type was added -kubernetes.io/dockercfg
, which is the OpenShift equivalent ofkubernetes.io/dockerconfigjson
.Basic OpenShift installation comes with 60+ namespaces beginning with
openshift-
prefix, which doesn't include additional namespaces created by OpenShift operators or customized installations, that would also be created with that prefix.For that case, I've excluded all
openshift-
namespaces in all relevant namespaced resource types, with the following pattern: