Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add helm charts with cronjob support #78

Merged
merged 6 commits into from
Sep 20, 2023
Merged

feat: add helm charts with cronjob support #78

merged 6 commits into from
Sep 20, 2023

Conversation

patricktalmeida
Copy link
Contributor

@patricktalmeida patricktalmeida commented Sep 12, 2023 •
edited
Loading

As discussed in #73, this is a separate PR to add Helm Charts, for now only containing CronJob, see issue #69.

This also covers #75

@patricktalmeida patricktalmeida mentioned this pull request Sep 12, 2023
Closed
@Yuni-sa Yuni-sa mentioned this pull request Sep 18, 2023
Closed
yonahd
yonahd reviewed Sep 18, 2023
View reviewed changes
Copy link
Owner

@yonahd yonahd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall
Please generate the readme for the Chart using
docker run --rm --volume "$(pwd):/helm-docs" -u "$(id -u)" jnorwood/helm-docs:v1.8.1

charts/kor/values.yaml Outdated Show resolved Hide resolved
charts/kor/Chart.yaml Outdated Show resolved Hide resolved
@yonahd yonahd linked an issue Sep 19, 2023 that may be closed by this pull request
Create Helm Chart For deploying Kor in Kubernetes #86
Closed
yonahd
yonahd reviewed Sep 20, 2023
View reviewed changes
charts/kor/values.yaml Outdated Show resolved Hide resolved
yonahd
yonahd approved these changes Sep 20, 2023
View reviewed changes
Copy link
Owner

@yonahd yonahd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yonahd yonahd merged commit f3235b0 into yonahd:main Sep 20, 2023
1 check passed
@patricktalmeida patricktalmeida deleted the add-helm-charts branch September 20, 2023 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yonahd yonahd yonahd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create Helm Chart For deploying Kor in Kubernetes
2 participants
@patricktalmeida @yonahd