Global install and uninstall #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm also thinking of changing the mint path from |
orta
reviewed
Dec 19, 2017
| let existingString: String = try file.read() | ||
| if !existingString.contains(exportSection) { | ||
| let newString = "\(existingString)\n\n\(exportSection)" | ||
| try file.write(newString) |
There was a problem hiding this comment.
Probably worth logging out that this is happening, but this makes sense to me 👍
|
|
||
| try files.forEach { | ||
| let file = Path($0).absolute() | ||
| if file.exists { |
There was a problem hiding this comment.
I am not sure if the use of a shell guarantees it will have a log‐on script. If the user has not configured anything yet, I do not know if the file would just be empty or completely non‐existent.
It is a clever way of checking which shells the user likely prefers, so I recommend keeping it this way for now unless someone files a bug.
and some test refactoring
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1
This allows installing a package globally. At the moment this is behind a
--globalflag, which may change to the default in the future.There is also an obligatory
uninstallcommand