Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix nested schemas in subclasses thinking they have a parent #128

Merged
merged 2 commits into from
Mar 4, 2019

Conversation

yonaskolb
Copy link
Owner

This fixes cases like the following:

ChildWithNestedObject:
      allOf:
        - $ref: '#/components/schemas/ParentObject'
        - type: object
          properties:
            data:
              type: object
              properties:
                value:
                  type: string

Before, the nested object was generated as if it was a subclass of ParentObject. This is due to how Stencil's include tag works, and that if a property isn't found in the context it looks in its parent.

@yonaskolb yonaskolb merged commit 046ec22 into master Mar 4, 2019
@yonaskolb yonaskolb deleted the fix/nested_child branch March 4, 2019 02:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant