Bugfix/StoreKitConfiguration BuildPhase #1026
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@liamnichols Thanks for bringing this issue up, I'd appreciate your review on this PR -- If you could also install this version locally, remove your manual |
liamnichols
approved these changes
Feb 23, 2021
There was a problem hiding this comment.
Thanks @jcolicchio 💯 I checked out your branch and removed my workaround and I can confirm that this works just like it did in 2.18.0 🙇
Awesome! @yonaskolb would you or someone else like to be the second reviewer? I think I saw @ainame liked the issue? |
yonaskolb
approved these changes
Feb 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the default build phase for .storekit files from .none to .resources, since this is required for tests which want to load an arbitrary storekit configuration at runtime.
For use in schemes only, we can add the .storekit file via fileGroups: so that it won't be associated with any target, and won't be included in any bundle resources
Fixes #1025