Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix localized files with same name #126

Merged
merged 4 commits into from
Nov 3, 2017

Conversation

ryohey
Copy link
Collaborator

@ryohey ryohey commented Nov 3, 2017

  • Refactor the code generating variant groups at e24c0e2 ce27af0. These do not change any output.
  • Fix localized files with same name at 66a2893. This will add localized files into the variant group that matches the file path with extension first. We use the variant group matched the file name without extension secondary for the case such as storyboard and strings.

close #122

- Use getFileReference() to generate localized file references
- Add name parameter to getFileReference
- Add getVariantGroup() in the same manner as getFileReference()
@yonaskolb
Copy link
Owner

Nice one! Thanks @ryohey!

@yonaskolb yonaskolb merged commit a9cbe51 into yonaskolb:master Nov 3, 2017
@yonaskolb
Copy link
Owner

By the way @ryohey I'm not sure if you're in the slack group, but you're welcome to join. We discuss XcodeGen and the projects from https://github.com/xcodeswift
http://xcodeswift.herokuapp.com

Anyone else who is reading this is free to join too, it's an open community 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Localised files with same name aren't generated properly
2 participants