Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support adding root files #293

Merged
merged 3 commits into from
Apr 12, 2018
Merged

Support adding root files #293

merged 3 commits into from
Apr 12, 2018

Conversation

yonaskolb
Copy link
Owner

This adds 2 things:

  • fixes files that are added as root sources from having invalid parent groups outside the project directory
  • add support for files in fileGroups. The name is a bit strange now though, perhaps we should rename it to files

@yonaskolb yonaskolb mentioned this pull request Apr 11, 2018
Merged
@yonaskolb
Copy link
Owner Author

@Lutzifer can you confirm that this fixes your issue?

@yonaskolb yonaskolb merged commit f62e24e into master Apr 12, 2018
@yonaskolb yonaskolb deleted the root_files branch April 12, 2018 13:07
@Lutzifer
Copy link
Contributor

Lutzifer commented Apr 12, 2018 •
edited
Loading

fixes files that are added as root sources from having invalid parent groups outside the project directory

this works for intermediateGroups

@Lutzifer
Copy link
Contributor

add support for files in fileGroups. The name is a bit strange now though, perhaps we should rename it to files

Also works, I just initially forgot to restart Xcode

@yonaskolb
Copy link
Owner Author

Ah great! 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yonaskolb @Lutzifer