Add recursive glob support

[bclymer]

Fixes #180.

Glob.swift comes from R.swift https://github.com/mac-cain13/R.swift/blob/master/Sources/RswiftCore/Util/Glob.swift, which was previously taken from other OS projects. Credits are provided in the header.

Glob itself comes with numerous tests, but I was also able to activate the previously commented out recursive globstar tests in XcodeGen. In addition, I added another scenario of a recursive globstar in a subdirectory, ensuring it does not match all directories, only those specified.

[brentleyjones]

🤤

I've been waiting for this.

[yonaskolb]

This is awesome, thank you @bclymer! This will make many people happy 😃
Could you please add the following:

• a changelog entry
• a comment in the ProjectSpec docs to say what type of glob we support. Looking at the imported code it seems to be BashV4?
• add some examples of recursive globs in the ProjectSpec doc excludes example

[yonaskolb]

This class already has too many functions (needs a refactor). For now can we just combine these two functions into one? Our basic currency type is always Path

[acecilia]

Thanks! @bclymer would it be possible to have the Glob code and tests as an independent Github project and swift package, so instead of having the source code in the project we can just add it to the Package.swift manifest?

[bclymer]

@yonaskolb sorry for the delay, I made the changes you requested.

@acecilia While I think that's a good idea, it feels a bit strange to me since it's not actually my code. Tracing back the links in the header comment it looks like it's been adapted from a number of gists, and then it moved to R.swift and has been modified there since.

[yonaskolb]

Thanks @bclymer! I just noticed some errors in the log from the new glob tests:

Error parsing file system item: Error Domain=NSCocoaErrorDomain Code=260 "The folder “dir2” doesn’t exist." UserInfo={NSFilePath=/tmp/glob-test.XBQ0m/dir2/, NSUserStringVariant=(
    Folder
), NSUnderlyingError=0x7fa8cdb00f20 {Error Domain=NSOSStatusErrorDomain Code=-43 "fnfErr: File not found"}}

https://github.com/yonaskolb/XcodeGen/pull/636/checks?check_run_id=208818534

Could we remove these errors

[bclymer]

@yonaskolb seeing that locally as well. I just didn't scroll up enough to see it originally. I'll get it resolved.

[acecilia]

@bclymer okey. I also think is a good idea, since I have seen already several projects rolling their own Glob implementations.

[bclymer]

Pushed a fix. The error was semi-intentional. It was testing a double globstar (tempDir/**/dir2/**/*), which evaluates all found directories in tempDir, but ** also means nonexistent, so it tested tempDir/dir2/**/* as well.

I've mainly silenced the warning by just checking if the path exists first, and then breaking out that rather large directory iteration block into it's own function.