Fix header phase for static frameworks #705
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not averse to adding a test for this but would need some guidance |
wag-miles
force-pushed
the
static_framework_headers
branch
from
a1fff7a
to
6293c17
Compare
|
Added a changelog entry. Not sure why the change is causing CI to fail |
CI is failing because Xcode 10.3 is no longer supported it seems. #707 will resolve it for the time being. |
|
@wag-miles please rebase on master to get the updated CI |
wag-miles
force-pushed
the
static_framework_headers
branch
from
6293c17
to
1dc7586
Compare
brentleyjones
approved these changes
Nov 6, 2019
|
Thanks @wag-miles! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Corrects a check that was removing all headers from static frameworks. #609