Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add (mode fallback) to installConfig.ml rule #76

Merged
merged 1 commit into from Aug 1, 2019
Merged

Add (mode fallback) to installConfig.ml rule #76

merged 1 commit into from Aug 1, 2019

Conversation

ghost
Copy link

@ghost ghost commented Jun 4, 2019

To make the behaviour explicit when the installConfig.ml exist in the source tree because configure.ml generated it. Currently, we get the following warning:

$ dune build -p camomile
File "Camomile/dune", line 2, characters 0-96:
2 | (rule (with-stdout-to installConfig.ml
3 |        (echo "let share_dir = \"/usr/share/camomile\"")))
Warning: File installConfig.ml is both generated by a rule and present in the source tree.
As a result, the rule is currently ignored, however this will become an error in the future.
To keep the current behavior and get rid of this warning, add a field (fallback) to the rule.

Signed-off-by: Jeremie Dimino <jeremie@dimino.org>
ghost referenced this pull request Jun 4, 2019
Signed-off-by: Jeremie Dimino <jeremie@dimino.org>
@Zimmi48 Zimmi48 mentioned this pull request Jun 4, 2019
10 tasks
@Mic92
Copy link

Mic92 commented Jun 4, 2019

Would be cool to get a new release that has this build fix included.

@rgrinberg rgrinberg merged commit d5e53b8 into yoriyuki:master Aug 1, 2019
rgrinberg added a commit to rgrinberg/opam-repository that referenced this pull request Aug 8, 2019
CHANGES:

- Use dune's include_subdirs (yoriyuki/Camomile#72)

- Fix parallel build (yoriyuki/Camomile#75)

- Add `(mode fallback)` to installConfig.ml (yoriyuki/Camomile#76)

- Fix iana executable (yoriyuki/Camomile#77)

- Generate opam files from dune. (yoriyuki/Camomile#78)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants