-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
How about recommending the use of 'prettier' in contribution guide? #53
Comments
Yes. It would be nice to describe However, it could not be introduced due to the line break issue below. Do you have any idea about this issue? |
@hackerwins Thank you for providing usable information. (reference) So I tested it with the code of the part in problem. printWidth: 80 if (logger.isEnabled(LogLevel.Trivial)) {
logger.trivial(
changes
.map(
(change) =>
`${change
.getID()
.getAnnotatedString()}\t${change.getAnnotatedString()}`,
)
.join('\n'),
);
} printWidth: 90 if (logger.isEnabled(LogLevel.Trivial)) {
logger.trivial(
changes
.map(
(change) =>
`${change.getID().getAnnotatedString()}\t${change.getAnnotatedString()}`,
)
.join('\n'),
);
} printWidth: 100 if (logger.isEnabled(LogLevel.Trivial)) {
logger.trivial(
changes
.map((change) => `${change.getID().getAnnotatedString()}\t${change.getAnnotatedString()}`)
.join('\n'),
);
} However, if we modify it and use it, it affects other parts as well. - pbSetOperation.setParentCreatedAt(
- toTimeTicket(setOperation.getParentCreatedAt()),
- );
+ pbSetOperation.setParentCreatedAt(toTimeTicket(setOperation.getParentCreatedAt())); Looking at this, I think there is a part that we have to give up in order for use prettier. |
For now, it would be nice to leave this issue open and wait for an update on Prettier. |
I found the modified code without
prettier
applied in some files during code modification.And it can include changes that are independent of the commit.
I sent a pull request for prevent this. (#52)
If the contributor modifies the code without using
prettier
, this problem will occur again.So how about recommending the use of 'prettier' in contribution guide?
The text was updated successfully, but these errors were encountered: