Introduce Prettier #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hackerwins
force-pushed
the
misc/prettier
branch
4 times, most recently
from
a2b8ad2
to
3edeca6
Compare
hackerwins
commented
Jun 13, 2020
src/document/document.ts
Outdated
Comment on lines
237
to
250
| logger.trivial(changes.map((change) => | ||
| `${change.getID().getAnnotatedString()}\t${change.getAnnotatedString()}` | ||
| ).join('\n')); | ||
| logger.trivial( | ||
| changes | ||
| .map( | ||
| (change) => | ||
| `${change | ||
| .getID() | ||
| .getAnnotatedString()}\t${change.getAnnotatedString()}`, | ||
| ) | ||
| .join('\n'), | ||
| ); |
There was a problem hiding this comment.
This seems harder to read. We need to find a way to prevent a newline per chained call.
https://eslint.org/docs/rules/newline-per-chained-call#ignorechainwithdepth
There was a problem hiding this comment.
hackerwins
force-pushed
the
misc/prettier
branch
from
3edeca6
to
c5f975f
Compare
hackerwins
force-pushed
the
misc/prettier
branch
from
c5f975f
to
4df5ed1
Compare
parkeunae
pushed a commit
to parkeunae/yorkie-js-sdk
that referenced
this pull request
Jul 23, 2022
* Apply prettier * Change code style of Prettier Co-authored-by: hyunwoo.jo <hyunwoo.jo@navercorp.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Change the code style of Prettier
How should this be manually tested?
Any background context you want to provide?
What are the relevant tickets?
Fixes #41
Checklist