Define JSONElement which represents the type exposed to the user #314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #314 +/- ##
==========================================
- Coverage 87.48% 87.44% -0.05%
==========================================
Files 70 70
Lines 4993 4993
Branches 505 505
==========================================
- Hits 4368 4366 -2
- Misses 441 443 +2
Partials 184 184
Continue to review full report at Codecov.
|
hackerwins
force-pushed
the
strict-typing
branch
2 times, most recently
from
304a1f5
to
9ca17d6
Compare
`json` gives the impression that it can be used directly by the users. So this commit changed the package that is not directly exposed to users to `crdt` and rename `proxy` to `json`. In addition, when the user uses custom methods on Array, it provides types with getID to the user. Conversely, if the user uses native methods, it returns types similar to the native interface as much as possible.
hackerwins
force-pushed
the
strict-typing
branch
from
9ca17d6
to
ee5e5ee
Compare
hackerwins
changed the title
hackerwins
added a commit
that referenced
this pull request
Jun 20, 2022
`json` gives the impression that it can be used directly by the users. So this commit changed the package that is not directly exposed to users to `crdt` and rename `proxy` to `json`. In addition, when the user uses custom methods on Array, it provides types with getID to the user. Conversely, if the user uses native methods, it returns types similar to the native interface as much as possible.
parkeunae
pushed a commit
to parkeunae/yorkie-js-sdk
that referenced
this pull request
Jul 23, 2022
`json` gives the impression that it can be used directly by the users. So this commit changed the package that is not directly exposed to users to `crdt` and rename `proxy` to `json`. In addition, when the user uses custom methods on Array, it provides types with getID to the user. Conversely, if the user uses native methods, it returns types similar to the native interface as much as possible.
2 tasks
hackerwins
added a commit
to yorkie-team/yorkie
that referenced
this pull request
Aug 16, 2022
hackerwins
added a commit
to yorkie-team/yorkie
that referenced
this pull request
Aug 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it?
Define JSONElement which represents the type exposed to the user.
Change the package exposed to users from
proxytojson.jsongives the impression that it can be used directly by the users. Sothis commit changed the package that is not directly exposed to users to
crdtand renameproxytojson.In addition, when the user uses custom methods on Array, it provides
types with getID to the user. Conversely, if the user uses native methods,
it returns types similar to the native interface as much as possible.
Any background context you want to provide?
What are the relevant tickets?
Fixes #
Checklist