Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert improvement text deletion #323

Merged
merged 2 commits into from
Jun 30, 2022
Merged

Revert improvement text deletion #323

merged 2 commits into from
Jun 30, 2022

Conversation

Eithea
Copy link
Contributor

@Eithea Eithea commented Jun 30, 2022

What this PR does / why we need it?

revert to the stable version

Any background context you want to provide?

What are the relevant tickets?

Fixes #

Checklist

  • Added relevant tests or not required
  • Didn't break anything

@codecov
Copy link

codecov bot commented Jun 30, 2022

Codecov Report

Merging #323 (b0ec008) into main (ab8bd87) will increase coverage by 0.30%.
The diff coverage is 93.75%.

@@            Coverage Diff             @@
##             main     #323      +/-   ##
==========================================
+ Coverage   87.44%   87.75%   +0.30%     
==========================================
  Files          70       70              
  Lines        5114     5047      -67     
  Branches      517      504      -13     
==========================================
- Hits         4472     4429      -43     
+ Misses        453      433      -20     
+ Partials      189      185       -4     
Impacted Files Coverage Δ
src/util/splay_tree.ts 91.82% <50.00%> (+9.55%) ⬆️
src/document/crdt/rga_tree_list.ts 85.95% <100.00%> (ø)
src/document/crdt/rga_tree_split.ts 93.46% <100.00%> (-0.19%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ab8bd87...b0ec008. Read the comment docs.

@hackerwins hackerwins self-requested a review June 30, 2022 05:36
Copy link
Member

@hackerwins hackerwins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!

@hackerwins hackerwins merged commit 34b88f7 into yorkie-team:main Jun 30, 2022
parkeunae pushed a commit to parkeunae/yorkie-js-sdk that referenced this pull request Jul 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants