Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add README and thumbnail on example 'simultaneous-cursors' #683

Merged
merged 7 commits into from
Nov 5, 2023

Conversation

banma1234
Copy link
Contributor

@banma1234 banma1234 commented Nov 4, 2023

What this PR does / why we need it?

Add README.md and thumbnail.jpg on example simultaneous-cursors.

There's no any docs on example simultaneous-cursors, and I need thumbnail and description to solve those issue.

Any background context you want to provide?

What are the relevant tickets?

Fixes #682

Checklist

  • Add thumbnil.jpg
  • Write README.md

Copy link
Member

@krapie krapie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution.

My personal opinion: how about changing text on the thumbnail to English so that many people can understand?

examples/simultaneous-cursors/README.md Outdated Show resolved Hide resolved
@krapie
Copy link
Member

krapie commented Nov 4, 2023

Seems like CI is failing. I'm having same issue on my local environment. Any ideas?
cc. @hackerwins

@hackerwins
Copy link
Member

The problem is related to golang/go#58550.

Copy link

codecov bot commented Nov 4, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (462e3d5) 67.92% compared to head (8d5a608) 67.89%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #683      +/-   ##
==========================================
- Coverage   67.92%   67.89%   -0.03%     
==========================================
  Files          58       58              
  Lines        8747     8747              
  Branches      788      788              
==========================================
- Hits         5941     5939       -2     
- Misses       2547     2548       +1     
- Partials      259      260       +1     

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hackerwins hackerwins self-requested a review November 5, 2023 01:15
Copy link
Member

@hackerwins hackerwins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution.

@hackerwins hackerwins merged commit ad38a15 into yorkie-team:main Nov 5, 2023
2 checks passed
@banma1234 banma1234 deleted the add_README branch November 5, 2023 06:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add README and thumbnail on example 'simultaneous-cursors'
3 participants