New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prevent deregisterElement from deregistering twice in nested object #716
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #716 +/- ##
=======================================
Coverage 81.76% 81.77%
=======================================
Files 57 57
Lines 4162 4164 +2
Branches 805 805
=======================================
+ Hits 3403 3405 +2
Misses 502 502
Partials 257 257 ☔ View full report in Codecov by Sentry. |
deregisterElement
must not deregister element twice in nested object
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution.
Looks good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution.
deregisterElement
must not deregister element twice in nested object
What this PR does / why we need it?
deregisterElement
function from deregistering twice in the nested object.deregisterElement
functionAny background context you want to provide?
Refer to issue #715 for details.
What are the relevant tickets?
Addresses #715
Checklist