Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add testcode for Duplicate deregister in GC #746

Closed
wants to merge 2 commits into from

Conversation

highcloud100
Copy link
Contributor

What this PR does / why we need it:

There was Duplicate deregister in Nested Object GC error in js sdk.
It was solved by js yorkie-js-sdk/PR #761.

There is no problem with existing code, but add test code that coverage this problem for later in case.

Which issue(s) this PR fixes:

Fixes #

Checklist:

  • Added relevant tests or not required
  • Didn't break anything

Copy link

codecov bot commented Jan 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8987b45) 49.27% compared to head (fbc7c6d) 49.30%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #746      +/-   ##
==========================================
+ Coverage   49.27%   49.30%   +0.03%     
==========================================
  Files          69       69              
  Lines       10087    10094       +7     
==========================================
+ Hits         4970     4977       +7     
  Misses       4601     4601              
  Partials      516      516              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hackerwins hackerwins marked this pull request as draft January 5, 2024 09:17
@highcloud100
Copy link
Contributor Author

Solved in #756

@highcloud100 highcloud100 deleted the duplicated_deregister branch January 25, 2024 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant