Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Firefox 106: Context Menu occationally disappear #109

Open
yorkxin opened this issue Nov 1, 2022 · 31 comments
Open

Firefox 106: Context Menu occationally disappear #109

yorkxin opened this issue Nov 1, 2022 · 31 comments

Comments

@yorkxin
Copy link
Owner

yorkxin commented Nov 1, 2022

Summary

Context menu is sometimes not showing up in Firefox 106.

Not always reproducible.

Edit: seems to be related to non-persistent background page.

@yorkxin yorkxin changed the title Firefox 106: Context Menu not displaying Firefox 106: Context Menu occationally disappear Nov 1, 2022
@manuzhang
Copy link

I'm seeing this issue now with Firefox 106.0.5. It always disappears.

@yorkxin
Copy link
Owner Author

yorkxin commented Nov 18, 2022

@manuzhang thanks. I'm using Firefox too, but I can't tell under what situation it appears or disappears...

@manuzhang
Copy link

Disabling and re-enabling the extension gives me back one item in the context menu. However, there should be more?
image

@yorkxin
Copy link
Owner Author

yorkxin commented Nov 18, 2022

@manuzhang thanks. I guess I know where the issue comes from (related: #107)

Regarding to the list of context menus, it depends on the item that you clicked. On a link it only shows Copy Link. On an image it shows Copy Image and Copy Image + Link command. On other places on the web page, it shows Copy Current Tab.

@manuzhang
Copy link

so is this already fixed in latest version?

@yorkxin
Copy link
Owner Author

yorkxin commented Nov 18, 2022

No, I think the issue still exists after #107 🥲 In fact I don't see context menu on my Firefox today.

@jman-schief
Copy link

If it helps I can reproduce this issue every time I update Firefox (I am on the beta channel so I receive updates quite often). After every update the context menu item disappears.

To workaround the issue I disable then enable again the extension, the context menu item is back.

@yorkxin
Copy link
Owner Author

yorkxin commented Mar 12, 2023

Dear folks, do you still experience this issue?

@jman-schief
Copy link

Dear folks, do you still experience this issue?

@yorkxin I do (Firefox 111.0b8). As per my previous comment, I just work around it :)

@manuzhang
Copy link

The issue still exists in 110.0.1 and I need to re-enable the extension to work around as well.

@yorkxin
Copy link
Owner Author

yorkxin commented May 12, 2023

Hi all, I've released a new version 2.8.3, and hopefully this time the issue gets resolved. Please let me know how it goes!

@jman-schief
Copy link

jman-schief commented May 13, 2023

@yorkxin thanks for working on this issue. on my firefox 114 the extension now behaves in a different way:

  • When installed for the first time (ex. using a new firefox profile), all's good
  • if I disable and enable the extension the context menu item does not show up anymore (so the addon is not usable)

As soon as I receive the next firefox update I can test what happens after updating the browser

EDIT: just updated to the latest firefox 114 beta and the context ment does not show up

@manuzhang
Copy link

@yorkxin Same for me on Firefox 113.0.1. Disabling and enabling the extension no longer works.

@jman-schief
Copy link

jman-schief commented May 17, 2023

I didnt investigate very deep but I think the issue is that there is no API under chrome.runtime. to catch the event when an extension is enabled by the user. I only see the onInstalled event that is triggered when the extension is first installed.

I've tried triggering a browser.contextMenus.create on window.onload and the context menu appears also when the user enable/disable the extension but it's not exactly what we want :-)

I'm not sure if we can get away without custom code for chrome, firefox-mv2 and firefox-mv3 🤷‍♂️

@azzamsa
Copy link

azzamsa commented May 19, 2023

Compared to other extension. It always warn me about "Permission needed to read and change data"
Firefox indicate this with a blue dot.

image

@azzamsa
Copy link

azzamsa commented May 26, 2023

I tried 113.0.2 but the context menu is still missing. I don't know why other context menu are there.

image

I have tried to use Brave because this extension works seamlessly in Brave. However, sometimes it needs a Google service extension. It is the reason I move back to Firefox.

I know it is an open-source project. It is not first-class paid ticket support. But I hope it will get resolved, as I use this extension a zillion times a day.

@azzamsa
Copy link

azzamsa commented May 30, 2023

After couple of day. Maybe restart / other updates I did. Now I can use the context menu in 113.0.2 🎉

image

@Ganton
Copy link

Ganton commented Jun 8, 2023

It also happens to me using Firefox 113.0.2, even after restarting it, and disabling and enabling Copy as Markdown...

@manuzhang
Copy link

The issue no longer exists in Firefox 114.0.2

@redeyes2015
Copy link

For me, after re-installing the extension in Firefox 114.0.2, and clicking the extension icon in the menu bar, the item in context menu shows up properly.

@manuzhang
Copy link

This issue reappeared in 115.0.2 (64-bit)

@jhermann
Copy link

Works for me in FF 102 32bit ESR, and does not in FF 116 64bit, both under Windows 11.

@Ganton
Copy link

Ganton commented Aug 29, 2023

Works for me in FF 102 32bit ESR, and does not in FF 116 64bit, both under Windows 11.

Does not work for me in FF 116 64bit under Linux.

@hesselmonk
Copy link

Ironically this issue is fixed for me by downgrading the plugin to Version 2.7.1 using FireFox 119.0 (64-bit) on Windows

@jman-schief
Copy link

As a reminder for those subscribed to this issue: I did a little investigation (see comment). If anyone wants to take it further and maybe submit a patch, I think that would be great.

@v-marinkov
Copy link

I just installed it for the first time and I was never able to see the context menu in Firefox 121. Any ideas?

@jman-schief
Copy link

jman-schief commented Jan 12, 2024

@v-marinkov to my knowledge, the only workaround is installing the previous version 2.7.1. After every update of Firefox the context menu will disappear: to have it back you'll have to disable and enable the extension

@StefanBrand
Copy link

I downgraded to version 2.7.1 and context menu immediately started to appear again.

@yorkxin
Copy link
Owner Author

yorkxin commented Apr 16, 2024

Memo: this is a known issue in Firefox MV3. https://discourse.mozilla.org/t/strange-mv3-behaviour-browser-runtime-oninstalled-event-and-menus-create/111208/14

Some extensions such as Leechblock NG, use a 1 second polling to recreate menus.

@yorkxin
Copy link
Owner Author

yorkxin commented Apr 16, 2024

Hi all, I've introduced a new version 2.9.1 as an attempt to resolve this issue. If the issue still exists, I will try to reimplement some code for the Firefox version. (For developers: Specifically, changing the extension's architecture from MV3 to MV2)

Please upgrade to 2.9.1 and see if the issue still exist. Thanks!

@manuzhang
Copy link

2.8.3 is working for me on Firefox 124.0.2 (64-bit)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

10 participants