Hack: Periodically re-create context menus in Firefox #127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In Firefox, when context menus were created in MV3, they may disappear unintentionally, even after restart. This is due to a bug in Firefox [1]. This patch introduces a hack which removes and re-creates all the menus every 30 seconds. [1]: https://discourse.mozilla.org/t/strange-mv3-behaviour-browser-runtime-oninstalled-event-and-menus-create/111208/7
yorkxin
changed the title
|
The menus have once disappeared in some tabs without appearing again. Refreshing the tab and the menus are back, but only in that specific tab. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In Firefox, when context menus were created in MV3, they may disappear unintentionally, even after restart. This is due to a bug in Firefox 1.
This patch introduces a hack which removes and re-creates all the menus every 30 seconds.
Related: #109
Tests
Optional: