Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: apply encoding when parse feilds #82

Merged
merged 6 commits into from
Oct 1, 2023
Merged

Conversation

merik-chen
Copy link
Contributor

Please kindly review the PR due to the multi-byte field name not getting properly parsed.

@yortus
Copy link
Owner

yortus commented Sep 8, 2023

Thanks for the contribution @merik-chen! I've pushed some changes to keep all the encoding selection logic in one place and use it consistently.

Do you have a file with non-latin-1 field names that can be added to the test fixtures, so we can add a test case for this?

@merik-chen
Copy link
Contributor Author

@yortus Sorry for the late replies. I added a test fixture with non-Latin-1 headers.

I can pass the reading test but failed the writing one.

It seems like still related to the header encoding problem after writing data to the file. seek your help to deal with it.

@yortus
Copy link
Owner

yortus commented Oct 1, 2023

Sorry for the delay @merik-chen. Thanks for adding the test file - it revealed another field name encoding bug which I've fixed. Merging now, thanks very much for your contribution!

@yortus yortus merged commit b5cae56 into yortus:master Oct 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants