Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add error handling to NGram fit function #75

Closed
stewu5 opened this issue Mar 8, 2019 · 0 comments
Closed

Add error handling to NGram fit function #75

stewu5 opened this issue Mar 8, 2019 · 0 comments
Assignees
@TsumiNa @stewu5

Comments

@stewu5
Copy link
Member

stewu5 commented Mar 8, 2019

When training for NGram, some SMILES may failed.
Instead of raising error directly, recording the SMILES that caused the error and continue on is important!
@stewu5 stewu5 added this to the v0.3.0 milestone Mar 8, 2019
@TsumiNa TsumiNa modified the milestones: v0.3.0, v0.4.0 Mar 14, 2019
@TsumiNa TsumiNa mentioned this issue Mar 18, 2019
Merged
@TsumiNa TsumiNa removed this from the v0.3.0 milestone Mar 18, 2019
TsumiNa added a commit that referenced this issue Mar 18, 2019
@TsumiNa
Closes #75 and Closes #86
19c1f54
TsumiNa added a commit that referenced this issue Mar 18, 2019
@TsumiNa
Merge branch 'feature/improve-docs' of https://github.com/yoshida-lab…
6a36c57 
…/XenonPy into feature/improve-docs

* 'feature/improve-docs' of https://github.com/yoshida-lab/XenonPy:
  check point
  check point
  release v0.3.0
  fix test in docker
  Update Dockerfile
  Closes #75 and Closes #86
  implement 1-dataset.rst. add some new sample codes
  Update features.rst
  Update features.rst
  check point
  Update features.rst
  Update features.rst
  check point
TsumiNa added a commit that referenced this issue Mar 20, 2019
@TsumiNa
Improve docs (#92)
e1eefc6 
* check point

* Update features.rst

* Update features.rst

* check point

* Update features.rst

* Update features.rst

* implement 1-dataset.rst.
add some new sample codes

* check point

* Closes #75 and Closes #86

* Update Dockerfile

print out api_key

* fix test in docker

* release v0.3.0

* check point

* check point

* Update features.rst

* Update features.rst

* implement 1-dataset.rst.
add some new sample codes

* check point

* check point

* fix test

* check point

* add r sample codes
improve mdl tests

* fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@TsumiNa TsumiNa

@stewu5 stewu5

Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@TsumiNa @stewu5