Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve NGram training #87

Merged

Conversation

TsumiNa
Copy link
Member

@TsumiNa TsumiNa commented Mar 18, 2019

Closes #75 and Closes #86

@TsumiNa TsumiNa added this to the v0.3.0 milestone Mar 18, 2019
@TsumiNa TsumiNa self-assigned this Mar 18, 2019
@TsumiNa TsumiNa changed the base branch from master to develop March 18, 2019 07:33
@codecov
Copy link

codecov bot commented Mar 18, 2019

Codecov Report

Merging #87 into develop will increase coverage by 0.08%.
The diff coverage is 80%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop      #87      +/-   ##
===========================================
+ Coverage    83.04%   83.13%   +0.08%     
===========================================
  Files           56       56              
  Lines         3940     3943       +3     
===========================================
+ Hits          3272     3278       +6     
+ Misses         668      665       -3
Impacted Files Coverage Δ
xenonpy/inverse/iqspr/modifier.py 85.4% <80%> (+1.49%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 07fc04b...bfab4df. Read the comment docs.

@TsumiNa TsumiNa merged commit 87a938c into develop Mar 18, 2019
@TsumiNa TsumiNa deleted the feature/add_error_handling_to_NGram_fit_function#75 branch March 24, 2019 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant