Refactor: return the amount of bytes if possible #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the winsock functions return the amount of affected (written or read) bytes directly. This result is only valid if the function returns success and invalid (error or WSA_IO_PENDING) otherwise. we map the success case to Some(bytes) and the case of IO_PENDING to None.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
THIS IS A BREAKING CHANGE! (Bump -> 0.2)
This unifies the API surface we expose here to always return an Option
where it makes sense.
the winsock functions return the amount of affected (written or read)
bytes directly. This result is only valid if the function returns
success and invalid (if an error or WSA_IO_PENDING is returned) otherwise.
we map the success case to Some(bytes) and the case of IO_PENDING to None.
We also use this opportunity, to add a possibility to pass a buffer into
connect_ex which is written after the connection is established,
so we can include connect_ex in the refactoring.
related to: tokio-rs/mio#520