Serializer: add support for passing serializer as string #108

yosiat · 2021-09-21T20:47:30Z

No description provided.

ryoung · 2022-05-13T20:10:25Z

lib/panko/serializer.rb

@@ -75,7 +75,7 @@ def method_added(method)

      def has_one(name, options = {})
        serializer_const = options[:serializer]
-        serializer_const = Panko::SerializerResolver.resolve(name.to_s, self) if serializer_const.nil?
+        serializer_const = Panko::SerializerResolver.resolve(name.to_s, self) if serializer_const.nil? || serializer_const.kind_of?(String)


@yosiat Is there a reason why you added support in the has_one method, but not the has_many method?

@ryoung umm don't think there was a specific reason..

want to submit a PR for that?

Yep, I can do that.

Serializer: add support for passing serializer as string

719cdaf

yosiat mentioned this pull request Sep 21, 2021

Attrribute methods not running #73

Open

yosiat merged commit cefad2f into master Feb 14, 2022

yosiat deleted the pass-serializer-string branch February 14, 2022 11:08

ryoung reviewed May 13, 2022

View reviewed changes

ryoung mentioned this pull request May 13, 2022

Add support for passing serializer as string in has_many association #118

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Serializer: add support for passing serializer as string #108

Serializer: add support for passing serializer as string #108

yosiat commented Sep 21, 2021

ryoung May 13, 2022

yosiat May 13, 2022

ryoung May 13, 2022

Serializer: add support for passing serializer as string #108

Serializer: add support for passing serializer as string #108

Conversation

yosiat commented Sep 21, 2021

ryoung May 13, 2022

Choose a reason for hiding this comment

yosiat May 13, 2022

Choose a reason for hiding this comment

ryoung May 13, 2022

Choose a reason for hiding this comment