hllSparseAdd(): more correct dense conversion conditional.

We want to promote if the total string size exceeds the resulting size after the upgrade.
yossigo · Apr 14, 2014 · 3b20003 · 3b20003
1 parent b7571b7
commit 3b20003
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/src/hyperloglog.c b/src/hyperloglog.c
@@ -801,7 +801,7 @@ int hllSparseAdd(robj *o, unsigned char *ele, size_t elesize) {
      int oldlen = is_xzero ? 2 : 1;
      int deltalen = seqlen-oldlen;
 
-     if (deltalen > 0 && sdslen(o->ptr) > HLL_SPARSE_MAX) goto promote;
+     if (deltalen > 0 && sdslen(o->ptr)+deltalen > HLL_SPARSE_MAX) goto promote;
      if (deltalen && next) memmove(next+deltalen,next,next-sparse);
      sdsIncrLen(o->ptr,deltalen);
      memcpy(p,seq,seqlen);