Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support exclude-old-transactions Request parameter #39

Merged
merged 2 commits into from
Jul 21, 2017

Conversation

brandon-clair
Copy link
Contributor

This adds support for sending the exclude-old-transactions Request parameter to App Store receipt validation.

Apple Docs
https://developer.apple.com/library/content/releasenotes/General/ValidateAppStoreReceipt/Chapters/ValidateRemotely.html

@coveralls
Copy link

coveralls commented Jul 19, 2017

Coverage Status

Coverage increased (+0.03%) to 88.657% when pulling b5e2fb7 on brandon-clair:master into 16ade8e on youknowone:master.

@codecov
Copy link

codecov bot commented Jul 19, 2017

Codecov Report

Merging #39 into master will increase coverage by 0.03%.
The diff coverage is 75%.

@@            Coverage Diff             @@
##           master      #39      +/-   ##
==========================================
+ Coverage   88.62%   88.66%   +0.03%     
==========================================
  Files           8        8              
  Lines         334      335       +1     
==========================================
+ Hits          296      297       +1     
  Misses         38       38

@youknowone
Copy link
Owner

Thanks for the new feature support. Can you add test for it? The test needs to cover both of True and False cases.

To make the change clear: the response format was not changed, right?

@brandon-clair
Copy link
Contributor Author

@youknowone A test has been added! Since the parameter is optional, and defaults to False, the current suite of tests cover that case. I have added a case where the parameter is submitted as True.

Correct, the response format has not been altered. This is to support a new, optional parameter for verification requests, exclude-old-transactions.

@coveralls
Copy link

coveralls commented Jul 20, 2017

Coverage Status

Coverage increased (+0.03%) to 88.657% when pulling 7c7e174 on brandon-clair:master into 16ade8e on youknowone:master.

3 similar comments
@coveralls
Copy link

Coverage Status

Coverage increased (+0.03%) to 88.657% when pulling 7c7e174 on brandon-clair:master into 16ade8e on youknowone:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.03%) to 88.657% when pulling 7c7e174 on brandon-clair:master into 16ade8e on youknowone:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.03%) to 88.657% when pulling 7c7e174 on brandon-clair:master into 16ade8e on youknowone:master.

@youknowone youknowone merged commit 1717207 into youknowone:master Jul 21, 2017
@youknowone
Copy link
Owner

I merged it, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants