Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/bts stills images #105

Merged
merged 35 commits into from
Nov 27, 2021
Merged

Feature/bts stills images #105

merged 35 commits into from
Nov 27, 2021

Conversation

ninabrissey
Copy link
Collaborator

Description

closes #44

  • Built out film stills functionality to the specs of the film fam
  • Added some error handling to the trailer form

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested?

  • Use console.log()
  • Dev tools / react dev tools
  • View in local host
  • Verify acceptance criteria (if applicable)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas

@ninabrissey
Change file names from Images to FilmStills
c162fa7
@ninabrissey
Change file import name
29de437
@ninabrissey
Adjust media queries
47fc9ad
@ninabrissey
Adjust gap on grid
49dda3b
@ninabrissey
Remove image scss import - filename weas changed
c9503cb
@ninabrissey
Change filename
6fed852
@ninabrissey
Update exports, filenames, imports for change from Images to FilmStills
d7f38f5
@ninabrissey
Build out basic FilmStillsCard
bf49d56
@ninabrissey
Build out basic FilmStillsContainer
b81c796
@ninabrissey
Build out basic FilmStillsDisplay
a83ccb0
@ninabrissey
Build out basic FilmStillsForm
27d959b
@ninabrissey
Remove included from FilmStillsContainer props
8b3cc69
@ninabrissey
Add id to fecth for getArrayData
01dd611
@ninabrissey
Remove duplicate components
f74cc80
@ninabrissey
Merge branch 'main' into feature/bts-stills-images
19abd33
@ninabrissey
Revert to old types
e663842
@ninabrissey
Refactor aws post for film_fams or film_stills
f2315e1
@ninabrissey
Add delete and build out card
d22773e
@ninabrissey
Add get and delete functionality
3a84362
@ninabrissey
Change classname, add props, remove comments
1360dc4
@ninabrissey
Adjust fetch calls for stills, add endpoint
366cb6b
@ninabrissey
Formatting of file changes - prettier
4953348
@ninabrissey
Adjust file formatting - prettier
4f839aa
@ninabrissey
Remove console.log, import new reusable post for fam and stills
7168958
@ninabrissey
Remove FilmsStillsForm input
fa000c6
@ninabrissey
Remove console.logs, add error handling to getArrayData
c711de9
@ninabrissey
Remove console.log
8ebd0ca
@ninabrissey
Add error handling for form
258a1b5
@ninabrissey
Set deafult of isEditing to true
add5beb
@ninabrissey
Adjust grid width
8023d3a
@ninabrissey ninabrissey added frontend frontend code styling CSS, HTML, accessibility architecture React, Router, Typescript development add new code labels Nov 27, 2021
rachelJensen
rachelJensen reviewed Nov 27, 2021
View reviewed changes
src/components/FilmStills/FilmStillsForm.tsx
setFilmStills([...filmStills, data.data])
);
})
.catch((err) => console.log(err));
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We probably want to add an actual error action here, instead of just the console.log. Just noting this for later

rachelJensen
rachelJensen approved these changes Nov 27, 2021
View reviewed changes
Copy link
Collaborator

@rachelJensen rachelJensen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So much work, here. Excited to finally have the stills incorporated. Nice job.

madhaus4
madhaus4 reviewed Nov 27, 2021
View reviewed changes
src/awsS3/helperFunctions.ts
@@ -91,7 +91,7 @@ export const postToDatabase = async (fileParams: any, epk: any, endpoint: string

//********** STEP 3 FOR FILM TEAM & FILM STILLS **********//

export const postFilmMemberToDatabase = async (fileParams: any, filmMember: any, endpoint: string) => {
export const postStillOrTeamToDB = async (keyID: any, fileParams: any, filmMember: any, endpoint: string) => {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for recycling this!

@madhaus4 madhaus4 merged commit 783c1e3 into main Nov 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@madhaus4 madhaus4 madhaus4 approved these changes

@rachelJensen rachelJensen rachelJensen approved these changes

Assignees

@madhaus4 madhaus4

@rachelJensen rachelJensen

Labels
architecture React, Router, Typescript development add new code frontend frontend code styling CSS, HTML, accessibility
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Image/Stills/BTS Display/Forms
3 participants
@ninabrissey @madhaus4 @rachelJensen