-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
reddit.com (Also new.reddit.com,old.reddit.com,www.reddit.com) Filter updates #194
Comments
I think I remember someone else finding maybe addressed in Adguard Annoyances, from what I remember, this may need a script inject to remove event listener -I will need to research and investigate more when I get the time, I have limited time right now to investigate further so any help from others would be appreciated! |
@yourduskquibbles After a bit of testing I found that the uBlock - Annoyances list fixes it with this filter:
|
@p4t44 Great! Thanks for looking into the fix - I have added your suggested filter. I should be able to test later today or tomorrow and confirm it is working, but please feel free to also test and let me know if there is still any issue. |
Yep works perfectly. Cant scroll before force updating the list, can straight after. While testing a came across a heap of other annoyances and put together an imgur album with screenshots and filters. You think you could add them? Thank you! Quick edit: im not sure if sub domains need to be specified? Filters for old reddit need to work on both www. and old. reddit.com and filters for new reddit need to work on both new. and www. reddit.com. Is an asterisk required or are these enforced everywhere automatically? Idk. |
Thanks for update! I will try to take a look at your suggested filters and add them today. |
@p4t44 for how about this filter That filter looks for the Still running through your other reports, no other questions/concerns so far. |
All proposed additional filters + a couple others I found. ! Filters for ad_placeholders.txt
! Filters for css_companion_filters.txt
! Filters for css_style_filters.txt
! Filters for modal_filters.txt
@p4t44 do you mind testing all of these filters for a day or so and see if they are causing any obvious site breakages before I add them to Web Annoyances Ultralist? You should be able to copy and paste the above code blocks and add them to |
I'll give them a test now but wouldn't be a better idea to give every *.reddit.com? Although it is probably a pretty small minority of Reddit use some subreddits force all internal links to be to np.reddit.com, some subreddits allow filtering of all political posts with a subdomain like nc.reddit.com and nm.reddit.com is used as an unofficial night mode on old reddit. New and old reddit can both be viewed on different subdomains. |
The ##.TopNav__promoButton annoyance is only visible on old reddit. The other filters work fine but they are only for mobile reddit, so the new reddit link isnt required?
This one does not work.
These new reddit sidebar box ones seem to work well, on new reddit there is not sidebar left at all when not signed in.
Impossible to test as the coronavirus box is gone now, but such boxes are frequent and will come again (and the same filter should block it).
Also needs to work on new.reddit.com
These ones work well in my limited testing.
These ones work well again in my limited testing. |
Another annoyance, RPAN ads in the reddit feed. I think it only happens one day a week, but it is very annoying. https://old.reddit.com/r/uBlockOrigin/comments/ezt8fg/blocking_rpan_from_reddit_feed/ might be useful. Ill do more thorough testing when I get back to my computer in a few days. Until then testing filters on mobile is hard. |
No I don't think so, based on past experience because there are some filters that should only be getting applied to
It would probably good to test on those domains, both logged in and logged out, if able can you provide working links for each subdomain that you know of? |
It should be working, can you test again? I believe a filter with just domain For the RPAN filter you suggest, I'd rather test & try to come up with a better filter when it is showing up, possible to bump this post when it is showing up? Thanks for all of the help with this. I've updated all other filters as suggested and a couple other updates, if possible, would you be able to test the updated set of filters below and let me know if working well? ! Reddit Test Filters (Click to expand)!!! Begin reddit test filters !! Filters for ad_placeholders.txt
!! Filters for css_companion_filters.txt
!! Filters for css_style_filters.txt
!! Filters for modal_filters.txt
!!! End reddit test filters |
>
> Back on my computer and testing, found one issue so far on new reddit. I don't think the shadow should be blocked.
How does adding the following two filters (plus the filters in #194 (comment)) work for you?
|
> Another thing, submit and about are missing from the sidebar.
@p4t44 I can't figure out how to reproduce this problem, is it logged in or not logged in? And for a specific subreddit or just on the homepage? Thanks for continued testing, as you can probably tell by now the reddit site is crazy CSS design structure :) |
Unfortunately this only creates more issues. Reddit with no custom filters applied Reddit with the new filters from your earlier comment Reddit with the filters from this comment as well as your earlier comment |
Tried again and it seems that this isn't being caused by the new filters or the webannoyancesultralist at all. Must be another list, sorry. |
URL(s) where the issue occurs
https://www.reddit.com/r/firefox/comments/ewvve9/can_we_all_agree_on_the_fact_that_reddit_should/ on Firefox for Android
Describe the issue
On a fresh install of Firefox for Android, after installing uBlock Origin, adding the web annoyances ultralist and visiting a post on reddit I cannot scroll
Screenshot(s)
Not useful as it is a scrolling issue, site visually looks the same wether you can scroll or not.
Versions
Settings
Notes
[Add here the result of whatever investigation work you have done: please investigate the issues you report -- this prevents burdening other volunteers. This is especially true for issues arising from settings which are very different from default ones.]
The text was updated successfully, but these errors were encountered: