Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

9to5Google\Mac websites - injected floating filter causes mobile view to have mis-aligned styling #494

Open
vonDubenshire opened this issue Jan 26, 2023 · 0 comments

Comments

@vonDubenshire
Copy link

vonDubenshire commented Jan 26, 2023

URL(s) where the issue occurs

https://www.9to5google.com

Describe the issue

9to5google.com and related websites are specifically called out in the WebAnnoyances Floating filter pulled in at the beginning of loading Web Annoyances.

Causes mis-alignment of icons at the top of the floating nav.

Screenshot(s)

https://i.vgy.me/etjRe7.png

Versions

  • Browser & Version: all Chromium browsers for sure.
  • Adblocker: uBlock Origin, Adguard Android nightly

Notes

I have found the issue is related to an "IMPORTANT" override in the CSS.

The FLOATING FILTERS include is responsible. See here:

9to5google.com,9to5mac.com,9to5toys.com,dronedj.com,electrek.co,spaceexplored.com##.header-icon-links a:style(height: 70px !important; line-height: 70px !important;)

https://raw.githubusercontent.com/yourduskquibbles/webannoyances/master/filters/floating_filters.txt#:~:text=9to5google.com%2C9to5mac.com%2C9to5toys.com%2Cdronedj.com%2Celectrek.co%2Cspaceexplored.com%23%23.header%2Dicon%2Dlinks%20a%3Astyle(height%3A%2070px%20!important%3B%20line%2Dheight%3A%2070px%20!important%3B)

I have added a screenshot here:

https://i.vgy.me/Np0qPS.png

Removing the IMPORTANT addition to the CSS, or adding !important to the 40px original styling, fixes the issue.

This may be the result of when 9to5 re-adjusted their header and navigation 6+ months ago.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant