New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hard to select items in IE10 Mobile #76
Comments
Is this just a css issue ? Maybe because the css uses px instead of ems ? On Fri, Dec 7, 2012 at 7:07 AM, Matt Cooper notifications@github.comwrote:
http://yourlabs.org http://blog.yourlabs.org |
That's a good question, and one I'll investigate first. |
I think it's more than a simple CSS fix. When the menu first loads, it's scrolled off the screen (and I can't tell if it's connected to another field or if that's an accident) just below the keyboard. I tried tapping it, but I get the same behavior as before (the tap is recognized on another field). Then when I tap back into the text box that's autocomplete-enabled, the menu pops right back up and is connected to the right field. I don't have more time to investigate tonight - another thing I need to try is testing it in desktop IE. |
Does it work on other mobile browsers ? |
I tested on Safari on iOS 6 (iPod Touch) and it worked correctly. I don't have any other mobile devices to test with. |
I haven't had any time to debug this - my bad. However, I did get a chance to try in desktop IE 10 and didn't have any troubles. This is good and bad, since it means it's mobile specific (and going to be "fun" to debug). |
If typeahead works in IE10 mobile, then it will be fixed when the "typeahead" branch is merged - probably for django-autocomplete-light 1.2 which can be expected in january. |
Wow, debugging on mobile browsers is a mess. I'll work around the issue for now - this isn't critical for me - and check again when typeahead is merged. Thanks! |
I just tried the typeahead branch experimentally. It's improved: when I tap the dropdown item, it sometimes selects that item. The menu is still not attached to the original field, and intermittently when I tap the dropdown item, it dismisses the menu without selecting the item (leaving me with a search query in a text box). |
I'm aware that selection of a choice doesn't work in the typeahead branch. It's probably the last major thing to fix in this branch. Could you try with 1.1.9 ? It has a rewritten keypress handler which might fix your issue. Thanks |
Also, I just updated the typeahead branch to use django-admin-bootstrapped and it seems like the autocomplete fully works. Could you try it too please ? Pretty please with a sugar on the top ⛵ |
Sure, I'll do that tonight and let you know. On Mon, Jan 21, 2013 at 9:03 AM, James Pic notifications@github.com wrote:
|
Actually I've got a problem in typeahead branch: you must either click very fast, either double click on a choice. Keyboard ENTER works... Anyway, I'm still interrested in your feedback. |
I updated to 1.1.9 from PyPI. Most of the bad behavior is fixed, though the I work at Microsoft and will file a bug against Mobile IE for them to take On Mon, Jan 21, 2013 at 9:58 AM, James Pic notifications@github.com wrote:
|
Hmm... actually, after I deployed to my public-facing site, now the Thoughts on what's going wrong there? On Tue, Jan 22, 2013 at 5:20 PM, Matt Cooper vtbassmatt@gmail.com wrote:
|
Is $ undefined ? That seems like a jquery loading problem. About the placement of the autocomplete, I'll give a shot at rewriting the autocomplete box placement part in autocomplete.js, to be more like twitter bootstrap typeahead. Thank you for your feedback. |
I made a lot of refactors in autocomplete.js. Besides the many keyboard navigation improvements, it includes a new autocomplete box placement strategy, which was copied from bootstrap typeahead. It might support your browsers. Since I intend to release this in 1.1.10, I've updated the demo site to use this branch, so you can test it directly from your browser by clicking this for example: http://jpic.pythonanywhere.com/admin/generic_m2m_autocomplete/modelgroup/add/ (user/pass: test) (Many other ideas where fetched from typeahead, resulting in a reduction of around 20 SLOCS hah !) |
Works great on Safari on my Mac. IE 10 doesn't fare as well.
Is that branch on PyPI yet? I want to grab and use it, and I'll serve a On Wed, Jan 23, 2013 at 10:25 AM, James Pic notifications@github.comwrote:
|
On Sun, Jan 27, 2013 at 3:43 PM, Matt Cooper notifications@github.com wrote:
Are you talking about the typeahead branch, where autocomplete.js is Or are you talking about the version >=1.1.10 which has backported Is there any way for me to debug on IE 10, desktop and mobile, without Thanks for your feedback Matt ! http://yourlabs.org |
I'm using the 1.1.10 version from PyPI. Desktop: If you have access to a Windows 8 machine, that's IE10 desktop. If Mobile: This works best on a native Windows install - I've had lots of Sorry to be such a pain in the ass. I'm unblocked on my personal project, ~matt On Sun, Jan 27, 2013 at 7:43 AM, James Pic notifications@github.com wrote:
|
Thanks a lot Matt. I tried most browsers on browerstack.com, which provides VMs through a flash interface. I tried most platforms including Windows 8 with IE10.0 both "vanilla" and "desktop" editions (didn't notice a difference) and it worked. You are of course not a pain in the ass, you're a great contributor. |
Just tested IE10 preview on windows 7 VM and it works. Is it normal ? I only have mouse and keyboard interface, no tapping... |
It only supports windows 8, which i can't install in VirtualBox (tried both 64bit and 32bit versions ... torrent downloaded of course so that might be a problem). |
Darn, that's the only good way I know to test IE 10 Mobile. Do you have any I was able to get Win8 running OK in VirtualBox, but the WinPhone emulator I think the problem in desktop IE may be the difference in how WebKit and On Tue, Jan 29, 2013 at 1:30 AM, James Pic notifications@github.com wrote:
|
Yeah, just tried using the mouse and it works flawlessly. So I'm going to I'll ask around if there's another way to try IE Mobile. Maybe some On Tue, Jan 29, 2013 at 11:48 AM, Matt Cooper vtbassmatt@gmail.com wrote:
|
I'm thinking, maybe it's because the input looses focus ? The autocomplete is ment to hide when the input looses focus. |
Am I going to have to buy a windows phone and return it after I have fixed the bug ? lol |
Hey Matt, I hope you're doing great. I was wondering if the problem persisted. Note that I have added support for IE8 recently ;) Thanks |
Hey, thanks for reaching out again. I'm up to 1.4.2 on my site right now Assuming it works, next oddball client will be Xbox One ;) I believe that's On Fri, Nov 29, 2013 at 3:32 AM, James Pic notifications@github.com wrote:
|
That would be amazing, thanksss Matt ! |
Nothing changed with 1.4.9 - didn't get better or worse :). It looks like I suspect the virtual keyboard is involved. It looks like d-a-l calculates On Fri, Nov 29, 2013 at 7:51 AM, James Pic notifications@github.com wrote:
|
Most v2 breakage is due to some class renamings I think. On Thu, Dec 5, 2013 at 6:39 AM, Matt Cooper notifications@github.comwrote:
http://yourlabs.org http://blog.yourlabs.org |
Cool, that's what I suspected given the errors I saw. Sent from my Windows Phone -----Original Message----- Most v2 breakage is due to some class renamings I think. On Thu, Dec 5, 2013 at 6:39 AM, Matt Cooper notifications@github.comwrote:
http://yourlabs.org http://blog.yourlabs.org |
Replace autocomplete_light.FixedModelForm by autocomplete_right.ModelForm On Thu, Dec 5, 2013 at 4:25 PM, Matt Cooper notifications@github.comwrote:
http://yourlabs.org http://blog.yourlabs.org |
Good news and bad news. Good: I got upgraded to 2.0.0a8 today. (Included a Bad news: it's still broken on IE mobile, and actually may be worse. I'm using Bootstrap 2.0 and Django Crispy Forms which may be playing a role On Thu, Dec 5, 2013 at 8:35 AM, James Pic notifications@github.com wrote:
|
Forgot the diff. On Mon, Dec 30, 2013 at 2:40 PM, Matt Cooper vtbassmatt@gmail.com wrote:
from b33rweb.models import Beer, Brewer, Style -autocomplete_light.register(Beer, search_fields=('name',),
-autocomplete_light.register(Brewer, search_fields=('name',),
-autocomplete_light.register(Style, search_fields=('name',),
----------------------------------- forms.py ----------------------------------- -class BrewerForm(ModelForm): @@ -18,10 +17,9 @@ class BrewerForm(ModelForm): -class BeerForm(ModelForm):
-class RatingForm(ModelForm):
@@ -50,12 +47,11 @@ class RatingForm(ModelForm): -class ServingForm(ModelForm):
@@ -94,7 +90,7 @@ class LoginForm(AuthenticationForm):
-class QuickEntryForm(ModelForm): |
Hi Matt, I'm sorry it's been a year since you opened this issue and I wasn't able to solve it due to lack of Xbox. You might know that I recently added Microsoft IE8 support #183 though. Please be sure that Xbox support could become a priority for v2 ! So this my postal address in case anyone from the xbox core devs would be able to send over the latest xbox: [removed for obvious security reasons] Please join a note with the name(s) you want to credit as sponsor ! I hope you enjoyed reading this comment as much as I did writing it. Sincerely |
I really wish I could send you one - unfortunately we don't have a broad For Xbox-related correspondence, feel free to use my work address: On Mon, Jan 6, 2014 at 6:01 PM, James Pic notifications@github.com wrote:
|
Well of course we have a test suite: http://travis-ci.org/yourlabs/django-autocomplete-light |
Of course :) I was thinking something more like a page that exercised all the On Tue, Jan 7, 2014 at 5:38 AM, James Pic notifications@github.com wrote:
|
Good news, it pretty much works on Xbox One. On Tue, Jan 7, 2014 at 5:49 AM, Matt Cooper vtbassmatt@gmail.com wrote:
|
On Wed, Jan 8, 2014 at 3:19 PM, Matt Cooper notifications@github.comwrote:
Nice One Xbox and IE team ! http://yourlabs.org http://blog.yourlabs.org |
I had the occasion to try it on a windows phone ... it is terrible indeed, apparently it doesn't it place right, but it just impossible to use because it seems like the browser doesn't create a touchable area per choice. Could you confirm that ? |
Prior to 2.0, it was pretty bad but if you stabbed your finger at it "just Wonder if it's a "pointer events vs touch events" or similar technical On Fri, Jan 10, 2014 at 3:07 AM, James Pic notifications@github.com wrote:
|
It would be great if you could show them and ask them why is IE making one big touchable area with the whole autocomplete instead of one touchable area per choice. Thanks ! |
Will do! Sent from my Windows Phone -----Original Message----- It would be great if you could show them and ask them why is IE making one big touchable area with the whole autocomplete instead of one touchable area per choice. |
Thanks a heap Matt ! Let me know if you change your mind for the xbox lol |
Hi Matt ! How's IE support these days ? Did the IE dev team had the chance to take a look ? Cheers |
I never could get them to engage. Luckily, it's working on IE11 which shipped with Phone 8.1. Since I'm the only user of my app and that's the OS I have, we're good :) I think I broke something because it stopped working on my wife's iPhone 6. But since I haven't needed it, I haven't investigated. And I'm pretty sure it's my fault because it was working on iOS in the past. Thanks for checking in! Sent from my Windows Phone -----Original Message----- Hi Matt ! |
Ok Matt it's awesome that the bug is fixed in IE 11 ;) Can we close this issue now ? |
Yes! I forgot it was still open. Thanks. Sent from my Windows Phone -----Original Message----- Ok Matt it's awesome that the bug is fixed in IE 11 ;) Can we close this issue now ? |
Thanks a heap ! |
The dropdown menus are really hard to tap in IE10 Mobile (Windows Phone 8). I have to zoom way in to successfully select an item. At the default zoom using Bootstrap's responsive CSS package, most of my taps are recognized as clicking the label of the field below. Works fine on Mobile Safari (iOS 6).
When I get a chance, I'll create an isolated test case, try to debug, and (if I find a solution) submit a patch. Creating a tracking issue for now.
It may be an interaction between this package and Crispy Forms - I haven't tried without Crispy.
The text was updated successfully, but these errors were encountered: