macOS X "Meld" wrapper script does not accept "--output <filename>" #42
Comments
gitster
pushed a commit
to git/git
that referenced
this issue
Jun 19, 2017
The macOS X fork of Meld[1] requires a "=" in the "--output" argument, as it uses a wrapper[2] script that munges the "--output" argument before calling into the common "meld" script. The macOS X wrapper script[2] accepts "--output=<filename>" only, despite the fact that the underlying meld code accepts both "--output <filename" and "--output=<filename>"[3]. All versions of meld which accept "--output" accept it in the "--output=<filename>" form, so use "--output=<file>" for maximum compatibility. [1] https://github.com/yousseb/meld [2] https://github.com/yousseb/meld/blob/master/osx/Meld [3] yousseb/meld#42 Reported-by: Matthew Groth <mgroth49@gmail.com> Helped-by: Samuel Lijin <sxlijin@gmail.com> Signed-off-by: David Aguilar <davvid@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
|
https://github.com/yousseb/meld/releases/tag/osx-11 |
|
https://github.com/yousseb/meld/releases/tag/osx-13 definitely fixes this issue after the removal of the wrapper script. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
meld itself uses optparse and accepts both
--output=<filename>and--output <filename>.The Meld wrapper script only accepts the former. It should accept the latter form as well.
This issue was originally reported to the Git project[1].
Git may work around the issue in a future version[2], but all Git versions going back to
v1.7.7use--output <filename>, so there's still probably a fair amount of users that would benefit from a fix.[1] https://public-inbox.org/git/20170619021033.22968-1-davvid@gmail.com/
[2] https://public-inbox.org/git/20170619021033.22968-1-davvid@gmail.com/
The text was updated successfully, but these errors were encountered: