Skip to content

Commit

Permalink
Enable base_unittests and net_unittests. (#463) (#479)
Browse files Browse the repository at this point in the history
- Fix the GLog implementation to use SB_LOG instead of std::cerr.

b/273820939

(cherry picked from commit e483010)

Co-authored-by: y4vor <yavor@google.com>
  • Loading branch information
cobalt-github-releaser-bot and y4vor committed May 26, 2023
1 parent 7041d6a commit 1230314
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 23 deletions.
10 changes: 0 additions & 10 deletions starboard/evergreen/arm/shared/cobalt/configuration.py
Original file line number Diff line number Diff line change
Expand Up @@ -66,14 +66,4 @@ def GetTestEnvVariables(self):
'PixelTest.CircularSubPixelBorder',
'PixelTest.FilterBlurred100PxText',
],
# These unittest cases are failing after llvm rebase. They will be fixed
# and re-enabled.
'base_unittests': [
'*',
],
# These unittest cases are failing after llvm rebase. They will be fixed
# and re-enabled.
'net_unittests': [
'*',
],
}
13 changes: 1 addition & 12 deletions starboard/evergreen/x64/cobalt/configuration.py
Original file line number Diff line number Diff line change
Expand Up @@ -39,15 +39,4 @@ def GetTestEnvVariables(self):
}
}

__FILTERED_TESTS = { # pylint: disable=invalid-name
# These unittest cases are failing after llvm rebase. They will be fixed
# and re-enabled.
'base_unittests': [
'*',
],
# These unittest cases are failing after llvm rebase. They will be fixed
# and re-enabled.
'net_unittests': [
'*',
],
}
__FILTERED_TESTS = {} # pylint: disable=invalid-name
5 changes: 4 additions & 1 deletion testing/gtest/include/gtest/internal/gtest-port.h
Original file line number Diff line number Diff line change
Expand Up @@ -1297,10 +1297,13 @@ class GTEST_API_ GTestLog {
};

#if !defined(GTEST_LOG_)

#if GTEST_OS_STARBOARD
#define GTEST_LOG_ SB_LOG
#else
# define GTEST_LOG_(severity) \
::testing::internal::GTestLog(::testing::internal::GTEST_##severity, \
__FILE__, __LINE__).GetStream()
#endif

inline void LogToStderr() {}
#if GTEST_OS_STARBOARD
Expand Down

0 comments on commit 1230314

Please sign in to comment.