Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable base_unittests and net_unittests. #463

Merged
merged 1 commit into from
May 26, 2023
Merged

Enable base_unittests and net_unittests. #463

merged 1 commit into from
May 26, 2023

Conversation

y4vor
Copy link
Contributor

@y4vor y4vor commented May 25, 2023

  • Fix the GLog implementation to use SB_LOG instead of std::cerr.

b/273820939

@y4vor y4vor added on_device runtest Trigger presubmit workflows. labels May 25, 2023
@y4vor
Enable base_unittests and net_unittests.
4a47c76 
- Fix the GLog implementation to use SB_LOG instead of std::cerr.

b/273820939
@y4vor y4vor merged commit e483010 into youtube:main May 26, 2023
@y4vor y4vor added the cp-24.lts.1+ Cherry Pick to the 24.lts.1+ branch label May 26, 2023
@cobalt-github-releaser-bot cobalt-github-releaser-bot mentioned this pull request May 26, 2023
Merged
cobalt-github-releaser-bot pushed a commit that referenced this pull request May 26, 2023
@y4vor @anonymous1-me
Enable base_unittests and net_unittests. (#463)
40323e3 
- Fix the GLog implementation to use SB_LOG instead of std::cerr.

b/273820939

(cherry picked from commit e483010)
y4vor added a commit that referenced this pull request May 26, 2023
@cobalt-github-releaser-bot @y4vor
Enable base_unittests and net_unittests. (#463) (#479)
1230314 
- Fix the GLog implementation to use SB_LOG instead of std::cerr.

b/273820939

(cherry picked from commit e483010)

Co-authored-by: y4vor <yavor@google.com>
@kaidokert kaidokert added cp-23.lts.1+ Cherry Pick to the 23.lts.1+ branch cp-22.lts.1+ Cherry Pick to the 22.lts.1+ branch cp-21.lts.1+ Cherry Pick to the 21.lts.1+ branch labels May 26, 2023
@cobalt-github-releaser-bot cobalt-github-releaser-bot mentioned this pull request May 26, 2023
Closed
cobalt-github-releaser-bot pushed a commit that referenced this pull request May 26, 2023
@y4vor @anonymous1-me
Enable base_unittests and net_unittests. (#463)
6aa5b73 
- Fix the GLog implementation to use SB_LOG instead of std::cerr.

b/273820939

(cherry picked from commit e483010)
@cobalt-github-releaser-bot cobalt-github-releaser-bot mentioned this pull request May 26, 2023
Closed
cobalt-github-releaser-bot pushed a commit that referenced this pull request May 26, 2023
@y4vor @anonymous1-me
Enable base_unittests and net_unittests. (#463)
0130035 
- Fix the GLog implementation to use SB_LOG instead of std::cerr.

b/273820939

(cherry picked from commit e483010)
@cobalt-github-releaser-bot cobalt-github-releaser-bot mentioned this pull request May 26, 2023
Closed
cobalt-github-releaser-bot pushed a commit that referenced this pull request May 26, 2023
@y4vor @anonymous1-me
Enable base_unittests and net_unittests. (#463)
bacac43 
- Fix the GLog implementation to use SB_LOG instead of std::cerr.

b/273820939

(cherry picked from commit e483010)
@kaidokert kaidokert removed cp-23.lts.1+ Cherry Pick to the 23.lts.1+ branch cp-22.lts.1+ Cherry Pick to the 22.lts.1+ branch cp-21.lts.1+ Cherry Pick to the 21.lts.1+ branch labels May 26, 2023
sideb0ard pushed a commit to sideb0ard/cobalt that referenced this pull request May 27, 2023
@y4vor @sideb0ard
Enable base_unittests and net_unittests. (youtube#463)
bb0915d 
- Fix the GLog implementation to use SB_LOG instead of std::cerr.

b/273820939
dmytro-golovchenko-luminartech pushed a commit to dmytro-golovchenko-luminartech/cobalt that referenced this pull request Jun 22, 2023
@y4vor @anonymous1-me
Enable base_unittests and net_unittests. (youtube#463)
87926c0 
- Fix the GLog implementation to use SB_LOG instead of std::cerr.

b/273820939

(cherry picked from commit 2766a1f [formerly e483010])


Former-commit-id: 0130035
dmytro-golovchenko-luminartech pushed a commit to dmytro-golovchenko-luminartech/cobalt that referenced this pull request Jun 22, 2023
@y4vor @anonymous1-me
Enable base_unittests and net_unittests. (youtube#463)
2ff03ab 
- Fix the GLog implementation to use SB_LOG instead of std::cerr.

b/273820939

(cherry picked from commit 2766a1f [formerly e483010])


Former-commit-id: 6aa5b73
dmytro-golovchenko-luminartech pushed a commit to dmytro-golovchenko-luminartech/cobalt that referenced this pull request Jun 22, 2023
@cobalt-github-releaser-bot @y4vor
Enable base_unittests and net_unittests. (youtube#463) (youtube#479)
5f97da3 
- Fix the GLog implementation to use SB_LOG instead of std::cerr.

b/273820939

(cherry picked from commit 2766a1f [formerly e483010])

Co-authored-by: y4vor <yavor@google.com>
Former-commit-id: 1230314
dmytro-golovchenko-luminartech pushed a commit to dmytro-golovchenko-luminartech/cobalt that referenced this pull request Jun 22, 2023
@y4vor @anonymous1-me
Enable base_unittests and net_unittests. (youtube#463)
0485999 
- Fix the GLog implementation to use SB_LOG instead of std::cerr.

b/273820939

(cherry picked from commit 2766a1f [formerly e483010])


Former-commit-id: bacac43
@y4vor y4vor deleted the enable_tests branch May 3, 2024 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaidokert kaidokert kaidokert approved these changes

@briantting briantting Awaiting requested review from briantting

Assignees
No one assigned
Labels
cp-24.lts.1+ Cherry Pick to the 24.lts.1+ branch runtest Trigger presubmit workflows.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@y4vor @kaidokert @andrewsavage1