Fixing OAuth redirect issue #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@iulukaya please merge this critical fix. Live Events are broken in the player without this. |
|
Can you sign a CLA so I can test and merge this? https://developers.google.com/open-source/cla/individual We've documented this process here: https://github.com/youtube/youtube-ios-player-helper/blob/master/CONTRIBUTING.md |
|
Already signed, thanks for merging! |
| options:NSRegularExpressionCaseInsensitive | ||
| error:&error]; | ||
| NSTextCheckingResult *staticProxyMatch = | ||
| [[staticProxyRegex firstMatchInString:url.absoluteString |
There was a problem hiding this comment.
Uhm, this seems to have a syntax error? There's an opening brace too much at the beginning.
There was a problem hiding this comment.
I proposed a fix in #116.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The patch fixes the issues discussed in #109. I have added additional regular expressions to prevent the UIWebView from taking the user out of the app when loading any URLs that look like https://accounts.google.com/o/oauth2/ or https://content.googleapis.com/static/proxy.html.
This is mainly a fix for Live Event videos. Tested with Video IDs
w-T2LJ_qLiw,nrYHu7hmMK0, andwpZNaYN29xs.@iulukaya please review and merge.